hiro/ray
1
0
Fork 0
mirror of https://github.com/vale981/ray synced 2025-03-05 10:01:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions
ray/.isort.cfg

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

27 lines
1.3 KiB
INI
Raw Permalink Normal View History

Add import sorting to format.sh (#25678) It will be easier to develop if we could use a tool to organize / sort imports and not have to move them around by hand. This PR shows how we could do this with isort (black doesn't quite do this per https://github.com/psf/black/issues/333) After this PR lands everyone will need to update their formatter to include isort if they don't have it already, i.e. pip install -r ./python/requirements_linters.txt All future file changes will go through isort and may introduce a slightly larger PR the first time as it will clean up the imports. The plan is to land this PR and also clean up the rest of the code in parallel by using this PR to format the codebase (so people won't get surprised by the formatter if the file hasn't been touched yet) Co-authored-by: Clarence Ng <clarence@anyscale.com>
2022-06-13 14:08:51 -07:00
[settings]
# This is to make isort compatible with Black. See
# https://black.readthedocs.io/en/stable/the_black_code_style.html#how-black-wraps-lines.
line_length=88
Make isort compatible with black (#25748) Make isort compatible with black
2022-06-13 23:00:48 -07:00
profile=black
Add import sorting to format.sh (#25678) It will be easier to develop if we could use a tool to organize / sort imports and not have to move them around by hand. This PR shows how we could do this with isort (black doesn't quite do this per https://github.com/psf/black/issues/333) After this PR lands everyone will need to update their formatter to include isort if they don't have it already, i.e. pip install -r ./python/requirements_linters.txt All future file changes will go through isort and may introduce a slightly larger PR the first time as it will clean up the imports. The plan is to land this PR and also clean up the rest of the code in parallel by using this PR to format the codebase (so people won't get surprised by the formatter if the file hasn't been touched yet) Co-authored-by: Clarence Ng <clarence@anyscale.com>
2022-06-13 14:08:51 -07:00
multi_line_output=3
include_trailing_comma=True
use_parentheses=True
float_to_top=True
apply isort uniformly for a subset of directories (#25824) Simplify isort filters and move it into isort cfg file. With this change, isort will not longer apply to diffs other than to files that are in whitelisted directory (isort only supports blacklist so we implement that instead) This is much simpler than building our own whitelist logic since our formatter runs multiple codepaths depending on whether it is formatting a single file / PR / entire repo in CI.
2022-06-17 13:40:32 -07:00
filter_files=True
Add import sorting to format.sh (#25678) It will be easier to develop if we could use a tool to organize / sort imports and not have to move them around by hand. This PR shows how we could do this with isort (black doesn't quite do this per https://github.com/psf/black/issues/333) After this PR lands everyone will need to update their formatter to include isort if they don't have it already, i.e. pip install -r ./python/requirements_linters.txt All future file changes will go through isort and may introduce a slightly larger PR the first time as it will clean up the imports. The plan is to land this PR and also clean up the rest of the code in parallel by using this PR to format the codebase (so people won't get surprised by the formatter if the file hasn't been touched yet) Co-authored-by: Clarence Ng <clarence@anyscale.com>
2022-06-13 14:08:51 -07:00
Update import sorting blacklist, enable sorting for experimental dir (#26101) Why are these changes needed? There are directories that we don't lint / format. Ensure they are also the case for the import sorting tool. Enable sorting for python/experimental to show case how to enable sorting for a directory as we convert more of the directories to be automatically sorted by the tool.
2022-07-12 21:25:58 -07:00
# Some of the directories need to be kept in the blacklist:
# python/ray/cloudpickle/*
# python/build/*
# python/ray/thirdparty_files/*
# python/ray/_private/thirdparty/*
# doc/*
# python/ray/__init__.py
# python/ray/setup-dev.py
apply isort uniformly for a subset of directories (#25824) Simplify isort filters and move it into isort cfg file. With this change, isort will not longer apply to diffs other than to files that are in whitelisted directory (isort only supports blacklist so we implement that instead) This is much simpler than building our own whitelist logic since our formatter runs multiple codepaths depending on whether it is formatting a single file / PR / entire repo in CI.
2022-06-17 13:40:32 -07:00
# For the rest we will gradually remove them from the blacklist as we
# reformat the code to follow the style guide.
Update import sorting blacklist, enable sorting for experimental dir (#26101) Why are these changes needed? There are directories that we don't lint / format. Ensure they are also the case for the import sorting tool. Enable sorting for python/experimental to show case how to enable sorting for a directory as we convert more of the directories to be automatically sorted by the tool.
2022-07-12 21:25:58 -07:00
skip_glob=doc/*,python/ray/__init__.py,python/ray/setup-dev.py,python/build/*,python/ray/cloudpickle/*,python/ray/thirdparty_files/*,python/ray/_private/thirdparty/*,python/ray/dag/*.py,ci/*,python/ray/_private/*,python/ray/air/*,python/ray/core/*,dashboard/*,python/ray/data/*,python/ray/includes/*,python/ray/internal/*,python/ray/ray_operator/*,python/ray/scripts/*,python/ray/serve/*,python/ray/serve/__init__.py,python/ray/sgd/*,python/ray/streaming/*,python/ray/tests/*,python/ray/tests/*,python/ray/train/*,python/ray/tune/*,python/ray/util/*,python/ray/workers/*,python/ray/workflow/*,rllib/*,release/*,
Add import sorting to format.sh (#25678) It will be easier to develop if we could use a tool to organize / sort imports and not have to move them around by hand. This PR shows how we could do this with isort (black doesn't quite do this per https://github.com/psf/black/issues/333) After this PR lands everyone will need to update their formatter to include isort if they don't have it already, i.e. pip install -r ./python/requirements_linters.txt All future file changes will go through isort and may introduce a slightly larger PR the first time as it will clean up the imports. The plan is to land this PR and also clean up the rest of the code in parallel by using this PR to format the codebase (so people won't get surprised by the formatter if the file hasn't been touched yet) Co-authored-by: Clarence Ng <clarence@anyscale.com>
2022-06-13 14:08:51 -07:00
Respect import order for psutil and setproctitle (#25780) Sort imports in a way that preserves the ordering requirements. This PR is needed for any file changes that imports psutil or setproctitle.
2022-06-14 17:44:41 -07:00
known_local_folder=ray
known_afterray=psutil,setproctitle
sections=FUTURE,STDLIB,THIRDPARTY,FIRSTPARTY,LOCALFOLDER,AFTERRAY
Reference in a new issue Copy permalink