Apply suggestions from code review

This commit is contained in:
Phillip Cloud 2024-05-01 05:04:00 -04:00 committed by GitHub
parent 8936c1c7af
commit 31f5bd3905
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -682,8 +682,6 @@ lib.composeManyExtensions [
});
deepspeed = super.deepspeed.overridePythonAttrs (old: rec {
# autoPatchelfIgnoreMissingDeps = true;
CUDA_HOME = pkgs.symlinkJoin {
name = "deepspeed-cuda-home";
paths = [
@ -693,7 +691,7 @@ lib.composeManyExtensions [
pkgs.cudaPackages.cuda_nvcc
];
};
buildInputs = (old.buildInputs or [ ])++ [ self.setuptools ];
buildInputs = old.buildInputs or [ ] ++ [ self.setuptools ];
LD_LIBRARY_PATH = "${CUDA_HOME}/lib";
preBuild = ''
# Prevent the build from trying to access the default triton cache directory under /homeless-shelter