From 6440e19c5794e2dcf584a03627142f07358e5e59 Mon Sep 17 00:00:00 2001 From: Harry van Haaren Date: Thu, 24 Nov 2016 23:49:05 +0000 Subject: [PATCH] Fixes #133 JackSendReturn defualt volume = 1.0f DSP and GUI level defaults for JackSend are now 1, so when you click the FX button, by default the audio will be routed to the send, returned, and audible again. This is better UX. Fixed 2 build warnings to do with string termination --- src/gtrack.cxx | 1 + src/jacksendreturn.cxx | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gtrack.cxx b/src/gtrack.cxx index be1a809..751b599 100644 --- a/src/gtrack.cxx +++ b/src/gtrack.cxx @@ -79,6 +79,7 @@ GTrack::GTrack(int x, int y, int w, int h, const char* l ) : jackSendActivate.callback(gtrack_jacksendactivate_cb,this); jackSendDial.align(FL_ALIGN_INSIDE); jackSendDial.callback(gtrack_jacksend_cb,this); + jackSendDial.value(1.0); //volBox.color( fl_rgb_color( 0,0,0 ) ); end(); // close the group diff --git a/src/jacksendreturn.cxx b/src/jacksendreturn.cxx index d8feff8..17c078d 100644 --- a/src/jacksendreturn.cxx +++ b/src/jacksendreturn.cxx @@ -4,12 +4,12 @@ #include extern Jack* jack; JackSendReturn::JackSendReturn(int trackid, AudioProcessor *prev, jack_client_t *client) - :m_trackid(trackid), m_previousProcessor(prev) + :m_trackid(trackid), m_previousProcessor(prev), m_sendvol(1.0f) { char name[50]; - sprintf(name, "Send_track_%d\0",trackid); + sprintf(name, "Send_track_%d\n",trackid); m_sendport=jack_port_register(client,name,JACK_DEFAULT_AUDIO_TYPE,JackPortIsOutput,0); - sprintf(name, "Return_track_%d\0",trackid); + sprintf(name, "Return_track_%d\n",trackid); m_returnport=jack_port_register(client,name,JACK_DEFAULT_AUDIO_TYPE,JackPortIsInput,0); m_active=false; m_counter=0;