Merge pull request #12 from mrvini/master

Removing unused variables initializations thanks @mrvini
This commit is contained in:
Brandon Nozaki Miller 2017-02-14 19:58:52 -08:00 committed by GitHub
commit c8b193095c
6 changed files with 40 additions and 151 deletions

1
.gitignore vendored Normal file
View file

@ -0,0 +1 @@
npm-debug.log

1
.npmignore Normal file
View file

@ -0,0 +1 @@
examples/

6
es5.js
View file

@ -9,8 +9,7 @@ function EventPubSub() {
function on(type,handler){
if(!handler){
const err=new ReferenceError('handler not defined.');
throw(err);
throw new ReferenceError('handler not defined.');
}
if(!this._events_[type]){
@ -27,8 +26,7 @@ function EventPubSub() {
}
if(!handler){
var err=new ReferenceError('handler not defined. if you wish to remove all handlers from the event please pass "*" as the handler');
throw err;
throw new ReferenceError('handler not defined. if you wish to remove all handlers from the event please pass "*" as the handler');
}
if(handler=='*'){

72
es6.js
View file

@ -1,85 +1,83 @@
'use strict';
class EventPubSub {
constructor(scope){
this._events_={};
this.publish=this.trigger=this.emit;
this.subscribe=this.on;
this.unSubscribe=this.off;
constructor( scope ) {
this._events_ = {};
this.publish = this.trigger = this.emit;
this.subscribe = this.on;
this.unSubscribe = this.off;
}
on(type,handler){
if(!handler){
const err=new ReferenceError('handler not defined.');
throw(err);
on( type, handler ) {
if ( !handler ) {
throw new ReferenceError( 'handler not defined.' );
}
if(!this._events_[type]){
this._events_[type]=[];
if ( !this._events_[ type ] ) {
this._events_[ type ] = [];
}
this._events_[type].push(handler);
this._events_[ type ].push( handler );
return this;
}
off(type,handler){
if(!this._events_[type]){
off( type, handler ) {
if ( !this._events_[ type ] ) {
return this;
}
if(!handler){
var err=new ReferenceError('handler not defined. if you wish to remove all handlers from the event please pass "*" as the handler');
throw err;
if ( !handler ) {
throw new ReferenceError( 'handler not defined. if you wish to remove all handlers from the event please pass "*" as the handler' );
}
if(handler=='*'){
delete this._events_[type];
if ( handler == '*' ) {
delete this._events_[ type ];
return this;
}
const handlers=this._events_[type];
const handlers = this._events_[ type ];
while(handlers.includes(handler)){
while ( handlers.includes( handler ) ) {
handlers.splice(
handlers.indexOf(handler),
handlers.indexOf( handler ),
1
);
}
if(handlers.length<1){
delete this._events_[type];
if ( handlers.length < 1 ) {
delete this._events_[ type ];
}
return this;
}
emit(type,...args){
if(!this._events_[type]){
return this.emit$(type,...args);
emit( type, ...args ) {
if ( !this._events_[ type ] ) {
return this.emit$( type, ...args );
}
const handlers=this._events_[type];
const handlers = this._events_[ type ];
for(let handler of handlers){
handler.apply(this, args);
for ( let handler of handlers ) {
handler.apply( this, args );
}
return this.emit$(type,...args);
return this.emit$( type, ...args );
}
emit$(type,...args){
if(!this._events_['*']){
emit$( type, ...args ) {
if ( !this._events_[ '*' ] ) {
return this;
}
const catchAll=this._events_['*'];
const catchAll = this._events_[ '*' ];
for(let handler of catchAll){
handler.call(this, type, ...args);
for ( let handler of catchAll ) {
handler.call( this, type, ...args );
}
return this;
}
}
module.exports=EventPubSub;
module.exports = EventPubSub;

File diff suppressed because one or more lines are too long

View file

@ -1,6 +1,6 @@
{
"name": "event-pubsub",
"version": "4.2.3",
"version": "4.2.4",
"description": "Super light and fast Extensible PubSub events and EventEmitters for Node and the browser with support for ES6 by default, and ES5 versions for older verions of node and older IE/Safari versions. Easy for any developer level. No frills, just high speed pubsub events!",
"main": "event-pubsub.js",
"directories": {