hiro/ement.el
1
0
Fork 0
mirror of https://github.com/vale981/ement.el synced 2025-03-04 17:01:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Comment: FIXMEs

Browse source
This commit is contained in:
Adam Porter 2021-09-18 17:18:52 -05:00
parent f97728e8ab
commit f8473134de
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ement-room.el
View file

@ -1047,12 +1047,16 @@ are sync batch tokens. Used for, e.g. filling gaps in
;; More pages remain to be loaded. ;; More pages remain to be loaded.
(let ((remaining-limit (- limit batch-size))) (let ((remaining-limit (- limit batch-size)))
(if (not (> remaining-limit 0)) (if (not (> remaining-limit 0))
;; FIXME: This leaves a gap if it's larger than 1,000 events.
;; Probably, the limit should be configurable, but it would be good
;; to find some way to remember the gap and fill it if the user
;; scrolls to it later (although that might be very awkward to do).
(display-warning 'ement-room-retro-to-token (display-warning 'ement-room-retro-to-token
(format "Loaded events in %S (%S) without filling gap; not filling further" (format "Loaded events in %S (%S) without filling gap; not filling further"
(ement-room-display-name room) (ement-room-display-name room)
(or (ement-room-canonical-alias room) (or (ement-room-canonical-alias room)
(ement-room-id room)))) (ement-room-id room))))
;; FIXME: Remove this message after testing. ;; FIXME: Remove this message after further testing.
(message "Ement: Continuing to fill gap in %S (%S) (remaining limit: %s)" (message "Ement: Continuing to fill gap in %S (%S) (remaining limit: %s)"
(ement-room-display-name room) (ement-room-display-name room)
(or (ement-room-canonical-alias room) (or (ement-room-canonical-alias room)
@ -1060,7 +1064,7 @@ are sync batch tokens. Used for, e.g. filling gaps in
remaining-limit) remaining-limit)
(ement-room-retro-to-token (ement-room-retro-to-token
room session end to :limit remaining-limit)))))))) room session end to :limit remaining-limit))))))))
;; FIXME: Remove this message after testing. ;; FIXME: Remove this message after further testing.
(message "Ement: Filling gap in %S (%S)" (message "Ement: Filling gap in %S (%S)"
(ement-room-display-name room) (ement-room-display-name room)
(or (ement-room-canonical-alias room) (or (ement-room-canonical-alias room)