hiro/ement.el
1
0
Fork 0
mirror of https://github.com/vale981/ement.el synced 2025-03-05 09:21:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Comment: Whitespace and TODOs

Browse source
This commit is contained in:
Adam Porter 2021-07-29 02:01:00 -05:00
parent d3d2de54d3
commit df5c3fe170
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ement-room.el
View file

@ -778,8 +778,8 @@ data slot."
(ement-room-timeline* room) nil)
;; We don't use `ement-room--insert-events' to avoid extra
;; calls to `ement-room--insert-ts-headers'.
;; TODO: Unify these event-insertion calls. Probably use `ement-room--insert-events' here.
(ement-room--process-events (ement-room-state room))
;; TODO: Move event insertion to defevent handlers.
(mapc #'ement-room--insert-event (ement-room-timeline room))
(ement-room--process-events (ement-room-timeline room))
(ement-room--insert-ts-headers))

5
ement.el
View file

@ -379,6 +379,7 @@ Runs `ement-sync-callback-hook' with SESSION."
(defun ement--update-room-buffers (session)
"Insert new events into SESSION's rooms which have buffers.
To be called in `ement-sync-callback-hook'."
;; TODO: Move this to ement-room.el, probably.
;; For now, we primitively iterate over the buffer list to find ones
;; whose mode is `ement-room-mode'.
(let* ((buffers (cl-loop for room in (ement-session-rooms session)
@ -425,14 +426,11 @@ To be called in `ement-sync-callback-hook'."
;; recent room name event. However, chronological order is not guaranteed, e.g. after
;; loading older messages (the "retro" function; this behavior is in development).
;; FIXME: Further mapping instead of alist-get.
;; Save room summary.
(dolist (parameter '(m.heroes m.joined_member_count m.invited_member_count))
(when (alist-get parameter summary)
;; These fields are only included when they change.
(setf (alist-get parameter (ement-room-summary room)) (alist-get parameter summary))))
;; Save state and timeline events.
(cl-macrolet ((push-events
(type accessor)
@ -457,6 +455,7 @@ To be called in `ement-sync-callback-hook'."
(cl-loop for event across (alist-get 'events ephemeral)
for event-struct = (ement--make-event event)
do (push event-struct (ement-room-ephemeral room))))
;; FIXME: This is a bit convoluted and hacky now. Refactor it.
(setf latest-timestamp
(max (push-events state ement-room-state)
(push-events timeline ement-room-timeline*)))