hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-05 07:41:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Rename jupyter-repl-display-traceback to jupyter-display-traceback

Browse source 
Also move the function to jupyter-client.el from jupyter-repl.el

* jupyter-repl.el (jupyter-repl-display-traceback): Do it.

* jupyter-client.el (jupyter-display-traceback): Do it.
This commit is contained in:
Nathaniel Nicandro 2018-11-17 16:31:39 -06:00
parent 872c5cde79
commit fca89359fd
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
jupyter-client.el
View file

@ -1839,6 +1839,15 @@ If RESTART is non-nil, request a restart instead of a complete shutdown."
(declare (indent 1))
nil)
(defun jupyter-display-traceback (traceback)
"Display TRACEBACK in a dedicated buffer."
(when (or (vectorp traceback) (listp traceback))
(setq traceback (concat (mapconcat #'identity traceback "\n") "\n")))
(jupyter-with-output-buffer "traceback" 'reset
(jupyter-insert-ansi-coded-text traceback)
(goto-char (point-min))
(display-buffer (current-buffer) '(display-buffer-below-selected))))
(cl-defgeneric jupyter-handle-error ((_client jupyter-kernel-client)
_req
_ename

11
jupyter-repl.el
View file

@ -884,15 +884,6 @@ buffer to display TEXT."
(jupyter-repl-append-output client req
(jupyter-insert-ansi-coded-text text))))))
(defun jupyter-repl-display-traceback (traceback)
"Display TRACEBACK in its own buffer."
(when (or (vectorp traceback) (listp traceback))
(setq traceback (concat (mapconcat #'identity traceback "\n") "\n")))
(jupyter-with-output-buffer "traceback" 'reset
(jupyter-insert-ansi-coded-text traceback)
(goto-char (point-min))
(display-buffer (current-buffer) '(display-buffer-below-selected))))
(cl-defmethod jupyter-handle-error ((client jupyter-repl-client)
req _ename _evalue traceback)
(when req
@ -900,7 +891,7 @@ buffer to display TEXT."
((eq (jupyter-message-parent-type
(jupyter-request-last-message req))
:comm-msg)
(jupyter-repl-display-traceback traceback))
(jupyter-display-traceback traceback))
(t
(jupyter-repl-append-output client req
(jupyter-insert-ansi-coded-text