hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-05 23:41:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Rework jupyter-requests-pending-p test

Browse source 
Getting failures on Appveyor
This commit is contained in:
Nathaniel Nicandro 2019-05-09 19:07:00 -05:00
parent ea8176d6fa
commit f7b0ab2bc1
2 changed files with 28 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
test/jupyter-test.el
View file

@ -42,7 +42,7 @@
;; re-used for the most part except for tests that explicitly start and stop a
;; process. Increasing these timeouts seemed to do the trick.
(when (or (getenv "APPVEYOR") (getenv "TRAVIS"))
(setq jupyter-long-timeout 20
(setq jupyter-long-timeout 30
jupyter-default-timeout jupyter-long-timeout))
(message "system-configuration %s" system-configuration)
@ -705,21 +705,32 @@
(ert-deftest jupyter-requests-pending-p ()
:tags '(client)
(jupyter-test-with-python-client client
(when-let* ((last-sent (gethash "last-sent" (oref client requests))))
(ignore-errors (jupyter-wait-until-idle last-sent)))
(let ((req (jupyter-send-kernel-info-request client)))
(ert-info ("Pending after send")
(should (jupyter-requests-pending-p client))
(jupyter-wait-until-idle req)
(should-not (jupyter-requests-pending-p client)))
(ert-info ("Pending until idle received")
(setq req (jupyter-send-execute-request client
:code "import time; time.sleep(0.2)"))
;; Empty out the pending-requests slot of CLIENT
(jupyter-wait-until-received :status req)
(should (jupyter-requests-pending-p client))
(jupyter-wait-until-idle req)
(should-not (jupyter-requests-pending-p client))))))
(let (pending)
(jupyter-with-timeout (nil jupyter-default-timeout)
(while (jupyter-requests-pending-p client)
(when-let* ((last-sent (gethash "last-sent" (oref client requests))))
(jupyter-wait-until-idle last-sent))))
;; Don't pass CLIENT to `should-not' because `ert' will attempt to
;; print the class object on failure and will fail at doing so.
(setq pending (jupyter-requests-pending-p client))
(should-not pending)
(let ((req (jupyter-send-kernel-info-request client)))
(ert-info ("Pending after send")
(setq pending (jupyter-requests-pending-p client))
(should pending)
(jupyter-wait-until-idle req)
(setq pending (jupyter-requests-pending-p client))
(should-not pending))
(ert-info ("Pending until idle received")
(setq req (jupyter-send-execute-request client
:code "import time; time.sleep(0.2)"))
;; Empty out the pending-requests slot of CLIENT
(jupyter-wait-until-received :status req)
(setq pending (jupyter-requests-pending-p client))
(should pending)
(jupyter-wait-until-idle req)
(setq pending (jupyter-requests-pending-p client))
(should-not pending))))))
(ert-deftest jupyter-eval ()
:tags '(client)

2
test/test-helper.el
View file

@ -184,7 +184,7 @@ If the `current-buffer' is not a REPL, this is identical to
(push el ,saved-sym))))))))
;; See the note about increasing timeouts during CI testing at the top
;; of jupyter-test.el
(accept-process-output nil 0.2)
(accept-process-output nil 0.5)
,@body)))
(defmacro jupyter-test-with-kernel-client (kernel client &rest body)