Remove channel in some jupyter-channel method names

This commit is contained in:
Nathaniel Nicandro 2018-01-04 23:27:41 -06:00
parent b19fdbbd10
commit cfdf68eb43
2 changed files with 6 additions and 6 deletions

View file

@ -85,17 +85,17 @@ A channel is alive if its socket property is bound to a
(and (slot-boundp channel 'socket)
(not (null (oref channel socket)))))
(cl-defmethod jupyter-channel-push-message ((channel jupyter-channel) msg)
(cl-defmethod jupyter-push-message ((channel jupyter-channel) msg)
(let ((ring (oref channel recv-queue)))
(ring-insert+extend ring msg 'grow)))
(cl-defmethod jupyter-channel-get-message ((channel jupyter-channel))
(cl-defmethod jupyter-get-message ((channel jupyter-channel))
(unless (ring-empty-p (oref channel recv-queue))
(cl-destructuring-bind (idents . msg)
(ring-remove (oref channel recv-queue))
msg)))
(cl-defmethod jupyter-channel-messages-available-p ((channel jupyter-channel))
(cl-defmethod jupyter-messages-available-p ((channel jupyter-channel))
(not (ring-empty-p (oref channel recv-queue))))
(defclass jupyter-hb-channel ()

View file

@ -303,7 +303,7 @@ using the CHANNEL's socket."
'(stdin-channel
shell-channel
iopub-channel)))))
(jupyter-channel-push-message channel data)
(jupyter-push-message channel data)
(run-with-timer 0.001 nil #'jupyter-handle-message client channel))))))
(cl-defmethod jupyter-start-channels ((client jupyter-kernel-client)
@ -496,8 +496,8 @@ are taken:
`jupyter-handle-execute-result',
`jupyter-handle-kernel-info-reply', ...
- Cleanup request when kernel is done processing it"
(when (jupyter-channel-messages-available-p channel)
(let* ((msg (jupyter-channel-get-message channel))
(when (jupyter-messages-available-p channel)
(let* ((msg (jupyter-get-message channel))
(pmsg-id (jupyter-message-parent-id msg))
(requests (oref client requests))
(req (gethash pmsg-id requests)))