hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-04 15:41:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Small refactoring

Browse source 
* jupyter-ioloop.el (jupyter-ioloop-printer): Add documentation, move it.
(jupyter-ioloop-start): Give a default implementation.
This commit is contained in:
Nathaniel Nicandro 2018-11-13 18:35:31 -06:00
parent 9d0976e1ed
commit 965b405312
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
jupyter-ioloop.el
View file

@ -124,6 +124,15 @@ while waiting using PROGRESS-MSG as the message."
(cl-check-type ioloop jupyter-ioloop)
(process-get (oref ioloop process) :last-event))
(cl-defgeneric jupyter-ioloop-printer (_ioloop _obj event)
"Return a printed representation of an IOLOOP EVENT.
IOLOOP, OBJ, and EVENT have the same meaning as in
`jupyter-ioloop-handler'.
This is mainly used for debugging purposes. The returned string
should exclude the head element of the EVENT."
(format "%s" (cdr event)))
(cl-defmethod jupyter-ioloop-handler :before ((ioloop jupyter-ioloop) obj event)
"Set the :last-event property of IOLOOP's process."
(with-slots (process) ioloop
@ -348,9 +357,6 @@ evaluation using `zmq-start-process'."
,@(oref ioloop teardown)
(zmq-prin1 '(quit)))))))
(cl-defmethod jupyter-ioloop-printer (_ioloop _obj event)
(format "%s" (cdr event)))
(defun jupyter-ioloop--filter (ioloop event)
(when jupyter--debug
(message
@ -365,10 +371,8 @@ evaluation using `zmq-start-process'."
;; object to be garbage collected if the IOLoop is killed.
(setf (oref ioloop object) nil)))
(cl-defgeneric jupyter-ioloop-start ((ioloop jupyter-ioloop) &rest _args)
"Start an IOLOOP.")
(cl-defmethod jupyter-ioloop-start ((ioloop jupyter-ioloop) object &key buffer)
(cl-defgeneric jupyter-ioloop-start ((ioloop jupyter-ioloop) object &key buffer)
"Start an IOLOOP.
OBJECT is an object which is used to dispatch on when the current
Emacs process receives an event to handle from IOLOOP, see