hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-05 23:41:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[WIP] Add ability to stop channels initially in jupyter-start-channels

Browse source 
Also add TODO about channel methods
This commit is contained in:
Nathaniel Nicandro 2018-01-08 22:42:50 -06:00
parent a9f2bac2c8
commit 839e5d855a
1 changed files with 19 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
jupyter-client.el
View file

@ -428,12 +428,24 @@ created for each channel which monitors the channel's socket for
input events. Note that this polling subprocess is not created
for the heartbeat channel."
(unless (oref client ioloop)
(when hb (jupyter-start-channel (oref client hb-channel)))
(oset client ioloop
(zmq-start-process
;; TODO: Currently there is no way to stop/start a channel individually
;; outside of this method. Create channel methods which are aware of a
;; client's ioloop so that you can send commands to the ioloop to start and
;; stop a channel. Also figure out a way to block until the ioloop says it
;; has finished with the operation. This may need changes in
;; `jupyter--ioloop'
(let ((ioloop (zmq-start-process
(jupyter--ioloop client)
(apply-partially #'jupyter--ioloop-filter client)
(apply-partially #'jupyter--ioloop-sentinel client)))))
(apply-partially #'jupyter--ioloop-sentinel client))))
(oset client ioloop ioloop)
(when hb (jupyter-start-channel (oref client hb-channel)))
(unless shell
(zmq-subprocess-send ioloop '(stop-channel :shell)))
(unless iopub
(zmq-subprocess-send ioloop '(stop-channel :iopub)))
(unless stdin
(zmq-subprocess-send ioloop '(stop-channel :stdin))))))
(cl-defmethod jupyter-stop-channels ((client jupyter-kernel-client))
"Stop any running channels of CLIENT."
@ -453,6 +465,7 @@ for the heartbeat channel."
'iopub-channel
'hb-channel
'stdin-channel)
;; FIXME: This does not work with the current implementation of channels
thereis (jupyter-channel-alive-p (slot-value client channel))))
;;; Message callbacks