hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-05 23:41:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[WIP] Remove old requests when dropping idle ones

Browse source
This commit is contained in:
Nathaniel Nicandro 2018-01-22 18:57:32 -06:00
parent 66f2837d8e
commit 7f09f14128
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
jupyter-client.el
View file

@ -716,14 +716,27 @@ that if no TIMEOUT is given, it defaults to
;;; Client handlers ;;; Client handlers
(defun jupyter--drop-idle-requests (client) (defun jupyter--drop-idle-requests (client)
"Drop completed/stale requests from CLIENT's request table.
Since there are no real guarantees on the order of messages
received by a Jupyter kernel. Requests that are stored in
CLIENT's requests slot are periodically removed once a request
has been idle for more than 1 minute. This avoids the request
table from growing without bound.
FIXME: A request is also removed if its last received message
time is more than 5 minutes ago. This is to ensure that any stale
requests that might have been complete, but the idle message was
not received, are also removed."
(cl-loop (cl-loop
with requests = (oref client requests) with requests = (oref client requests)
with ctime = (current-time) with ctime = (current-time)
for req in (hash-table-values requests) for req in (hash-table-values requests)
for ltime = (jupyter-request-last-message-time req) for ltime = (jupyter-request-last-message-time req)
for id = (jupyter-request-id req) for id = (jupyter-request-id req)
when (and (jupyter-request-idle-received-p req) when (or (and (jupyter-request-idle-received-p req)
(> (float-time (time-subtract ctime ltime)) 60)) (> (float-time (time-subtract ctime ltime)) 60))
;; Remove stale requests
(> (float-time (time-subtract ctime ltime)) 300))
do (when jupyter--debug do (when jupyter--debug
(message "DROPPING-REQ: %s" id)) (message "DROPPING-REQ: %s" id))
(remhash id requests))) (remhash id requests)))