hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-05 23:41:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add note about subprocess lifetime

Browse source
This commit is contained in:
Nathaniel Nicandro 2018-01-22 18:50:04 -06:00
parent fa2658f168
commit 66f2837d8e
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
jupyter-client.el
View file

@ -405,6 +405,11 @@ PRIORITIES - An alist of (CTYPE . PRIORITY) pairs where CTYPE is
;; in `jupyter--ioloop-queue-message'. For some reason the `condition-case' in
;; `zmq--init-subprocess' is not sending back the error. Or more specifically,
;; in the subprocess errors are being turned into warnings.
;;
;; TODO: Ensure that the subprocess gets killed when the parent emacs exits.
;; This may not happen if the parent emacs crashes. One solution is to send the
;; process id of the parent emacs and periodically check if the process is
;; still alive, then exit the subprocess if the parent process is dead.
(defun jupyter--ioloop (client)
"Return the function used for communicating with CLIENT's kernel."
(let* ((session (oref client session))