hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-05 07:41:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove the status handler for jupyter-org-clients

Browse source 
The work done by the status handler is now done by the execute reply handler.
This commit is contained in:
Nathaniel Nicandro 2018-11-21 12:28:33 -06:00
parent c5a03da4e0
commit 5555faa785
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
jupyter-org-client.el
View file

@ -104,15 +104,6 @@ source code block. Set by `org-babel-execute:jupyter'.")))
(insert (ansi-color-apply text)))
(buffer-string))))
(cl-defmethod jupyter-handle-status ((_client jupyter-org-client)
(req jupyter-org-request)
execution-state)
(when (equal execution-state "idle")
(message "Code block evaluation complete.")
(when (jupyter-org-request-async req)
(jupyter-org--clear-request-id req)
(run-hooks 'org-babel-after-execute-hook))))
;;; Errors
(defvar jupyter-org-goto-error-map
@ -219,15 +210,21 @@ to."
(jupyter-org--add-result req (jupyter-org-result req data metadata)))
(cl-defmethod jupyter-handle-execute-reply ((client jupyter-org-client)
(_req jupyter-org-request)
_status
(req jupyter-org-request)
status
execution-count
_user-expressions
payload)
;; TODO: Re-use the REPL's handler somehow?
(oset client execution-count (1+ execution-count))
(when payload
(jupyter-repl--handle-payload payload)))
(jupyter-repl--handle-payload payload))
(if (equal status "ok")
(message "Code block evaluation complete.")
(message "An error occurred when evaluating code block."))
(when (jupyter-org-request-async req)
(jupyter-org--clear-request-id req)
(run-hooks 'org-babel-after-execute-hook)))
;;; Completions in code blocks