hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-06 07:51:39 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup REPL launching commands

Browse source 
* jupyter-repl.el
(jupyter-run-repl): Don't treat interactive calls separately from
non-interactive ones, validation of the kernel name in both types of
calls is done now by using `jupyter-guess-kernelspec`.  Use
`jupyter-client` to launch the kernel and connect a client.
(jupyter-connect-repl): Use `jupyter-client`.
This commit is contained in:
Nathaniel Nicandro 2020-04-22 11:39:17 -05:00
parent d137540061
commit 2ccab95d0e
1 changed files with 7 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
jupyter-repl.el
View file

@ -2101,13 +2101,10 @@ command on the host."
t nil t))
(or client-class (setq client-class 'jupyter-repl-client))
(jupyter-error-if-not-client-class-p client-class 'jupyter-repl-client)
(unless (called-interactively-p 'interactive)
(or (when-let* ((spec (car (jupyter-find-kernelspecs kernel-name)))
(name (jupyter-kernelspec-name spec)))
(setq kernel-name name))
(error "No kernel found for prefix (%s)" kernel-name)))
(let ((client (jupyter-client (jupyter-kernel-process :spec kernel-name) client-class)))
(jupyter-bootstrap-repl client repl-name associate-buffer display)))
(jupyter-bootstrap-repl
;; TODO: Just make this `jupyter-kernelspec'
(jupyter-client (jupyter-guess-kernelspec kernel-name) client-class)
repl-name associate-buffer display))
;;;###autoload
(defun jupyter-connect-repl (file &optional repl-name associate-buffer client-class display)
@ -2127,11 +2124,9 @@ like the symbol `jupyter-repl-client', which is the default. "
t nil t))
(or client-class (setq client-class 'jupyter-repl-client))
(jupyter-error-if-not-client-class-p client-class 'jupyter-repl-client)
(let ((client (make-instance client-class))
(kernel (jupyter-kernel :conn-info file)))
(jupyter-connect client kernel)
(jupyter-hb-unpause client)
(jupyter-bootstrap-repl client repl-name associate-buffer display)))
(jupyter-bootstrap-repl
(jupyter-client (jupyter-kernel :conn-info file) client-class)
repl-name associate-buffer display))
(provide 'jupyter-repl)