hiro/emacs-jupyter
1
0
Fork 0
mirror of https://github.com/vale981/emacs-jupyter synced 2025-03-05 07:41:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove some method implementations

Browse source 
The `jupyter-kill-kernel` of a kernel manager serves no purpose, just
use `jupyter-shutdown-kernel`.

* jupyter-kernel-manager.el
(jupyter-kill-kernel) [jupyter-kernel-manager]: Remove.

* jupyter-server.el (jupyter-kill-kernel) [jupyter-server-kernel-manager]: Remove.
This commit is contained in:
Nathaniel Nicandro 2020-04-13 16:20:52 -05:00
parent a7dbff9aa3
commit 25270f7d3b
2 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
jupyter-kernel-manager.el
View file

@ -155,9 +155,6 @@ SLOTS are the slots used to initialize the client with.")
"Shutdown MANAGER's kernel or restart instead if RESTART is non-nil. "Shutdown MANAGER's kernel or restart instead if RESTART is non-nil.
Wait until TIMEOUT before forcibly shutting down the kernel.") Wait until TIMEOUT before forcibly shutting down the kernel.")
(cl-defmethod jupyter-kill-kernel ((manager jupyter-kernel-manager))
(jupyter-shutdown-kernel manager))
(cl-defgeneric jupyter-interrupt-kernel ((manager jupyter-kernel-manager) &rest args) (cl-defgeneric jupyter-interrupt-kernel ((manager jupyter-kernel-manager) &rest args)
"Interrupt MANAGER's kernel. "Interrupt MANAGER's kernel.
When the kernel has an interrupt mode of \"message\" send an When the kernel has an interrupt mode of \"message\" send an

3
jupyter-server.el
View file

@ -471,9 +471,6 @@ receiving events on the websocket when this method returns."
(with-slots (kernel) manager (with-slots (kernel) manager
(jupyter-api-interrupt-kernel (oref kernel server) (oref kernel id)))) (jupyter-api-interrupt-kernel (oref kernel server) (oref kernel id))))
(cl-defmethod jupyter-kill-kernel ((manager jupyter-server-kernel-manager))
(jupyter-shutdown-kernel manager))
(cl-defmethod jupyter-shutdown-kernel ((manager jupyter-server-kernel-manager) &optional restart _timeout) (cl-defmethod jupyter-shutdown-kernel ((manager jupyter-server-kernel-manager) &optional restart _timeout)
(with-slots (kernel) manager (with-slots (kernel) manager
(let ((server (oref kernel server))) (let ((server (oref kernel server)))