mirror of
https://github.com/vale981/emacs-ipython-notebook
synced 2025-03-06 17:41:40 -05:00
![]() Previous change was not complete since the test does NOT fail. The test must fail because the test was for `full' undo but actually it was tested against normal undo. It turned out let binding of buffer-undo-list in ein-cell.el was the right way to do it, since EWOC does some buffer modification outside of the pretty printer. Therefore, setting inhibit-read-only and buffer-undo-list in the pretty printer makes no sense. Thus, they are removed from ein:notebook-pp. This means that wrapping EWOC functions with let binding of buffer-undo-list is essential. Meaning that what I wrote in the FIXME ein:notebook-pp was wrong. Therefore, ein:notebook-empty-undo-maybe cannot be called in ein:notebook-pp and ein:notebook-empty-undo-maybe must be called in every single functions that modifies buffer via EWOC. Tests for three cases of undo configuration are added. These test still fail: ein:notebook-undo-after-execution-1-cell/yes ein:notebook-undo-after-execution-2-cells/yes |
||
---|---|---|
.. | ||
mocker@2000d037ea | ||
notebook | ||
func-test.el | ||
setup-server.el | ||
test-ein-cell-notebook.el | ||
test-ein-cell.el | ||
test-ein-kernel.el | ||
test-ein-kill-ring.el | ||
test-ein-node.el | ||
test-ein-notebook.el | ||
test-ein-notification.el | ||
test-ein-utils.el | ||
test-load.el |