Commit graph

89 commits

Author SHA1 Message Date
Takafumi Arakaki
20af5c2840 Remove eintest:cell-json-data-code (add ein-testing-cell.el)
Use ein:testing-codecell-data instead.
To do that, I make new testing module ein-testing-cell.el and
move ein:testing-*cell-data functions there.
2012-08-25 00:16:41 +02:00
Takafumi Arakaki
056cff7d7f Add more assertions in ein:notebook-from-json-all-cell-types 2012-08-25 00:03:04 +02:00
Takafumi Arakaki
b9e94a9a7a Add test ein:notebook-from-json-all-cell-types 2012-08-24 23:44:27 +02:00
Takafumi Arakaki
3068c39fcf Fix failing tests 2012-08-24 20:18:09 +02:00
Takafumi Arakaki
96d2babff1 Move test utils to ein-testing-notebook.el
So that I can avoid loading test-ein-notebook or
test-ein-cell-notebook for using these utilities.
2012-08-24 19:29:37 +02:00
Takafumi Arakaki
cbef38f13c Add tests for command ein:worksheet-execute-cell-and-* 2012-08-21 14:04:35 +02:00
Takafumi Arakaki
f7ed3be032 Fix misuse of prefix-arg (use current-prefix-arg)
sed -i -E -e 's/([^-])prefix-arg/\1current-prefix-arg/g' */*.el
2012-08-20 12:47:09 +02:00
Takafumi Arakaki
a0651292a4 Fix ein:worksheet-split-cell-at-point
It failed when there is no text after the point in cell.
Note that it seems that this bug existed before the "worksheet" branch.
2012-08-20 12:39:02 +02:00
Takafumi Arakaki
d3bf631204 Rename: ...cells -> ein:worksheet-kill-cell
This is for symmetry with ein:worksheet-yank-cell
2012-08-20 11:22:33 +02:00
Takafumi Arakaki
8156f160cf Fix test ein:notebook-undo-via-events 2012-08-20 10:22:24 +02:00
Takafumi Arakaki
865ffcf09e Fix ein:notebook-delete-cell-command-no-undo
This test should delete a cell instead of kill, as the name suggest.
2012-08-20 10:15:15 +02:00
Takafumi Arakaki
bd2008696c Fix ein:notebook-change-cell-type-cycle-through 2012-08-20 10:06:13 +02:00
Takafumi Arakaki
5a409422cc Fix typo: ein:worksheet-kill-cells
%s/\(ein:worksheet-kill-cell\)\b/\1s/g
2012-08-20 09:59:11 +02:00
Takafumi Arakaki
2a74ec2b64 Fix ein:get-cell-at-point/traceback-data--worksheet 2012-08-20 09:43:39 +02:00
Takafumi Arakaki
8d773d9d4b Fix eintest:notebook-from-json 2012-08-20 09:38:15 +02:00
Takafumi Arakaki
1a823e7568 Finish fixing compiler warning in test-ein-notebook.el 2012-08-20 09:32:13 +02:00
Takafumi Arakaki
87f4d16c5c Fix eintest:notebook-split-cell-at-point 2012-08-20 09:27:51 +02:00
Takafumi Arakaki
89c8305ee0 Fix test ein:notebook-change-cell-type-cycle-through 2012-08-20 09:27:33 +02:00
Takafumi Arakaki
59263b270f Rename (most of) functions in test-ein-notebook.el
%s/ein:notebook-\(ncells\) ein:%notebook%/ein:worksheet-\1 ein:%worksheet%
%s/ein:notebook-\(get-cells\) ein:%notebook%/ein:worksheet-\1 ein:%worksheet%
%s/(ein:notebook-\(insert-cell-below\)-command)/(call-interactively #'ein:worksheet-\1)/
%s/(ein:notebook-\(insert-cell-above\)-command)/(call-interactively #'ein:worksheet-\1)/
%s/(ein:notebook-\([a-z\-]+\)-command)/(call-interactively #'ein:worksheet-\1)/
%s/(ein:notebook-get-current-cell)/(ein:worksheet-get-current-cell)/
%s/(ein:notebook-toggle-cell-type)/(call-interactively #'ein:worksheet-toggle-cell-type)/g
2012-08-20 09:23:29 +02:00
Takafumi Arakaki
5afc60c768 Add test ein:notebook-undo-via-events 2012-08-19 13:13:01 +02:00
Takafumi Arakaki
ecd7a2c044 Fix failing unit tests
* Undocumented returned value of ein:notebook-request-open-callback
  (previously notebook buffer, now notebook) is used.
  Now this implicit dependency is removed.

* ein:notebook-opened-map renamed to ein:notebook--opened-map
2012-08-19 03:40:59 +02:00
Takafumi Arakaki
c6ca4facd0 Use ein:%notebook% in test-ein-notebook.el
%s/\_<ein:\(notebook\)\_>/ein:%\1%/g
2012-08-19 00:24:16 +02:00
Takafumi Arakaki
383f3003bf Fix tests for console integration 2012-08-16 16:40:57 +02:00
Takafumi Arakaki
0aac7b2026 Add tests ein:get-*--notebook 2012-08-14 22:31:48 +02:00
Takafumi Arakaki
84f3d2d67c Add tests for ein:notebook--check-nbformat 2012-08-12 19:33:57 +02:00
Takafumi Arakaki
4308b8ba9f Reverse the direction to merge
Rational to do this is this makes split+merge an identity operation.
2012-08-01 23:19:37 +02:00
Takafumi Arakaki
d4d1b0c9aa Fix ein:notebook-merge-cell-command undo spec
Follow the specification written in ein:notebook-enable-undo.
2012-08-01 23:04:48 +02:00
Takafumi Arakaki
22848bdd91 Use the output area of the bottom cell when merge
fixes #37
2012-08-01 23:02:17 +02:00
Takafumi Arakaki
b3050b27ef Preserve output of the bottom cell when splitting
Also eintest:notebook-undo-after-split is fixed.  Previous test
was actually wrong.  Note that (ein:notebook-empty-undo-maybe)
is added to make the test pass for ein:notebook-enable-undo=yes.
The current behavior is what mentioned in ein:notebook-enable-undo.

fixes (part of) #37
2012-08-01 22:44:00 +02:00
Takafumi Arakaki
c1b0eab11d Document eintest:notebook-split-cell-at-point 2012-08-01 22:02:37 +02:00
Takafumi Arakaki
13e9e7f29b Add a test ein:notebook-change-cell-type-cycle-through 2012-07-21 15:02:07 +02:00
Takafumi Arakaki
0e910b46fd Fix test: ein:notebook-toggle-cell-type-simple 2012-07-21 14:41:09 +02:00
Takafumi Arakaki
c104a0b19d Rename ein:kernel-ready-p to ein:kernel-live-p 2012-07-19 00:37:30 +02:00
Takafumi Arakaki
7d81026f2c Fix ein:notebook-merge-cell-command
Let binding of buffer-undo-list of shadowed the global variable.
2012-06-17 09:50:45 +02:00
Takafumi Arakaki
fb4ed0b449 Add more tests for undo 2012-06-17 08:59:04 +02:00
Takafumi Arakaki
6b5b54c965 Trigger ein:notebook-empty-undo-maybe via event
Previous tests were failed because undo was not reset after the
execution callbacks modified the buffer.  This is fixed by calling
ein:notebook-empty-undo-maybe via event in all the callbacks.
2012-06-16 23:42:58 +02:00
Takafumi Arakaki
0c13bc4234 Modifying undo in PP is wrong
Previous change was not complete since the test does NOT fail.
The test must fail because the test was for `full' undo but
actually it was tested against normal undo.

It turned out let binding of buffer-undo-list in ein-cell.el
was the right way to do it, since EWOC does some buffer
modification outside of the pretty printer.  Therefore, setting
inhibit-read-only and buffer-undo-list in the pretty printer
makes no sense.  Thus, they are removed from ein:notebook-pp.

This means that wrapping EWOC functions with let binding of
buffer-undo-list is essential.  Meaning that what I wrote in
the FIXME ein:notebook-pp was wrong.  Therefore,
ein:notebook-empty-undo-maybe cannot be called in ein:notebook-pp
and ein:notebook-empty-undo-maybe must be called in every single
functions that modifies buffer via EWOC.

Tests for three cases of undo configuration are added.
These test still fail:
ein:notebook-undo-after-execution-1-cell/yes
ein:notebook-undo-after-execution-2-cells/yes
2012-06-16 23:42:23 +02:00
Takafumi Arakaki
5b06f8fcd8 More precise check in undo tests 2012-06-16 21:04:47 +02:00
Takafumi Arakaki
7bf8acd484 Rename to ein:notebook-undo-after-execution-1-cell 2012-06-16 20:42:14 +02:00
Takafumi Arakaki
4f3695c4cf Refactor ein:notebook-undo-after-execution*
.. and ein:notebook-execute-current-cell.
2012-06-16 20:41:27 +02:00
Takafumi Arakaki
1127de66a7 Add two tests for undo in notebook 2012-06-16 20:12:56 +02:00
Takafumi Arakaki
35c3e9bd7b Fix ein:notebook-execute-current-cell
"Hellow World" for eintest:kernel-fake-stream had unnecessary single
quotes.
2012-06-16 19:00:44 +02:00
Takafumi Arakaki
c0839fa795 Refactor ein:notebook-execute-current-cell more (2) 2012-06-16 18:58:27 +02:00
Takafumi Arakaki
74a433dd7b Refactor ein:notebook-execute-current-cell more 2012-06-16 18:51:56 +02:00
Takafumi Arakaki
6aef0678f1 Refactor ein:notebook-execute-current-cell 2012-06-16 18:45:01 +02:00
Takafumi Arakaki
05b699e50e Improve test ein:notebook-yank-cell-command-simple 2012-06-06 02:03:14 +02:00
Takafumi Arakaki
e9210fe644 Cosmetic changes on code alignment 2012-06-04 16:23:53 +02:00
Takafumi Arakaki
93199a392b Remove cell from kernel-execute callbacks 2012-06-04 16:18:17 +02:00
Takafumi Arakaki
be0c3665b9 Fix ein:notebook-toggle-cell-type: set kernel
Set kernel slot if the converted cell is a code cell.
2012-06-02 21:47:03 +02:00
Takafumi Arakaki
77d574dc73 Fix test: ein:notebook-toggle-cell-type-simple 2012-06-02 20:59:14 +02:00