hiro/emacs-ipython-notebook
1
0
Fork 0
mirror of https://github.com/vale981/emacs-ipython-notebook synced 2025-03-05 17:11:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

ein-company: Add completion caching, make caching kernel specific.

Browse source
This commit is contained in:
John Miller 2018-11-22 09:07:02 -07:00
parent f8ac77df66
commit e280bb8633
4 changed files with 41 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lisp/ein-classes.el
View file

@ -247,6 +247,7 @@
stdin-activep
username
msg-callbacks
oinfo-cache
;; FIXME: Use event instead of hook.
after-start-hook
after-execute-hook)

32
lisp/ein-company.el
View file

@ -95,9 +95,10 @@
minor-mode-list)
(ein:object-at-point)))
(annotation (if ein:allow-company-annotations
(ein:aif (gethash arg *ein:oinfo-cache*)
(plist-get it :definition)
"")))
(let ((kernel (ein:get-kernel)))
(ein:aif (gethash arg (ein:$kernel-oinfo-cache kernel))
(plist-get it :definition)
""))))
(doc-buffer (lexical-let ((arg arg))
(cons :async
(lambda (cb)
@ -108,17 +109,20 @@
(ein:pytools-find-source (ein:get-kernel-or-error)
obj
cb)))))
(candidates () (lexical-let ((kernel (ein:get-kernel-or-error))
(col (current-column)))
(unless (ein:company-backend--punctuation-check (thing-at-point 'line) col)
(case ein:completion-backend
(ein:use-company-jedi-backend
(cons :async (lambda (cb)
(ein:company--complete-jedi cb))))
(t
(cons :async
(lambda (cb)
(ein:company--complete cb))))))))))
(candidates () (or
(ein:completions--find-cached-completion (ein:object-at-point)
(ein:$kernel-oinfo-cache (ein:get-kernel-or-error)))
(lexical-let ((kernel (ein:get-kernel-or-error))
(col (current-column)))
(unless (ein:company-backend--punctuation-check (thing-at-point 'line) col)
(case ein:completion-backend
(ein:use-company-jedi-backend
(cons :async (lambda (cb)
(ein:company--complete-jedi cb))))
(t
(cons :async
(lambda (cb)
(ein:company--complete cb)))))))))))
(defun ein:company-backend--punctuation-check (thing col)

37
lisp/ein-completer.el
View file

@ -128,10 +128,13 @@ notebook buffers and connected buffers."
;;; Retrieving Python Object Info
(defvar *ein:oinfo-cache* (make-hash-table :test #'equal))
(defun ein:completions--reset-oinfo-cache (kernel)
(setf (ein:$kernel-oinfo-cache kernel) (make-hash-table :test #'equal)))
(defun ein:completions--reset-oinfo-cache ()
(setf *ein:oinfo-cache* (make-hash-table :test #'equal)))
(defun ein:completions--find-cached-completion (partial oinfo-cache)
(loop for candidate being the hash-keys of oinfo-cache
when (string-prefix-p partial candidate)
collect candidate))
(defun ein:completions--get-oinfo (obj)
(let ((d (deferred:new #'identity))
@ -146,22 +149,23 @@ notebook buffers and connected buffers."
d))
(defun ein:completions--build-oinfo-cache (objs)
(dolist (o (-non-nil objs))
(deferred:$
(deferred:next
(lambda ()
(ein:completions--get-oinfo (ein:trim o "\\s-\\|\n\\|\\."))))
(deferred:nextc it
(lambda (output)
(ein:completions--prepare-oinfo output o))))))
(let ((kernel (ein:get-kernel)))
(dolist (o (-non-nil objs))
(deferred:$
(deferred:next
(lambda ()
(ein:completions--get-oinfo (ein:trim o "\\s-\\|\n\\|\\."))))
(deferred:nextc it
(lambda (output)
(ein:completions--prepare-oinfo output o kernel)))))))
(defun ein:completions--prepare-oinfo (output obj)
(defun ein:completions--prepare-oinfo (output obj kernel)
(condition-case err
(destructuring-bind (msg-type content _) output
(ein:case-equal msg-type
(("stream" "display_data" "pyout" "execute_result")
(ein:aif (plist-get content :text)
(setf (gethash obj *ein:oinfo-cache*) (ein:json-read-from-string it))))
(setf (gethash obj (ein:$kernel-oinfo-cache kernel)) (ein:json-read-from-string it))))
(("error" "pyerr")
(ein:log 'error "ein:completions--prepare-oinfo: %S" (plist-get content :traceback)))))
;; It's okay, bad things happen. Not everything in python is going to have a
@ -170,13 +174,14 @@ notebook buffers and connected buffers."
;; register a debug message in case someone really needs to know what is
;; happening.
(error (ein:log 'debug "ein:completions--prepare-oinfo: [%s] %s" err obj)
(setf (gethash obj *ein:oinfo-cache*) :json-false))))
(setf (gethash obj (ein:$kernel-oinfo-cache kernel)) :json-false))))
;;; Support for Eldoc
(defun ein:completer--get-eldoc-signature ()
(let ((func (ein:function-at-point)))
(ein:aif (gethash func *ein:oinfo-cache*)
(let ((func (ein:function-at-point))
(kernel (ein:get-kernel)))
(ein:aif (gethash func (ein:$kernel-oinfo-cache kernel))
(ein:kernel-construct-defstring it)
(ein:completions--build-oinfo-cache (list func)))))

1
lisp/ein-kernel.el
View file

@ -77,6 +77,7 @@
:websocket nil
:base-url base-url
:stdin-activep nil
:oinfo-cache (make-hash-table :test #'equal)
:username "username"
:msg-callbacks (make-hash-table :test 'equal)))