Add no-popup option to ein:jupyter-server-start

This commit is contained in:
Edward Banner 2018-03-26 19:54:34 -07:00
parent 115c16eb9f
commit e17819f918

View file

@ -101,7 +101,7 @@ session, along with the login token."
(list nil nil)))))) (list nil nil))))))
;;;###autoload ;;;###autoload
(defun ein:jupyter-server-login-and-open () (defun ein:jupyter-server-login-and-open (&optional no-popup)
"Log in and open a notebooklist buffer for a running jupyter notebook server. "Log in and open a notebooklist buffer for a running jupyter notebook server.
Determine if there is a running jupyter server (started via a Determine if there is a running jupyter server (started via a
@ -116,14 +116,14 @@ via a call to `ein:notebooklist-open'."
(progn (progn
(ein:notebooklist-login url-or-port token) (ein:notebooklist-login url-or-port token)
(sit-for 1.0) ;; FIXME: Do better! (sit-for 1.0) ;; FIXME: Do better!
(ein:notebooklist-open url-or-port)) (ein:notebooklist-open url-or-port nil no-popup))
(if url-or-port (if url-or-port
(ein:notebooklist-open url-or-port) (ein:notebooklist-open url-or-port)
(ein:log 'info "Could not determine port nor login info for jupyter server.")))))) (ein:log 'info "Could not determine port nor login info for jupyter server."))))))
;;;###autoload ;;;###autoload
(defun ein:jupyter-server-start (server-cmd-path notebook-directory &optional no-login-after-start-p) (defun ein:jupyter-server-start (server-cmd-path notebook-directory &optional no-login-after-start-p no-popup)
"Start the jupyter notebook server at the given path. "Start the jupyter notebook server at the given path.
This command opens an asynchronous process running the jupyter This command opens an asynchronous process running the jupyter
@ -191,7 +191,7 @@ the log of the running jupyter server."
(ein:jupyter-server-stop t)) (ein:jupyter-server-stop t))
(ein:force-ipython-version-check) (ein:force-ipython-version-check)
(unless no-login-p (unless no-login-p
(ein:jupyter-server-login-and-open)))))))) (ein:jupyter-server-login-and-open no-popup))))))))
;;;###autoload ;;;###autoload