hiro/emacs-ipython-notebook
1
0
Fork 0
mirror of https://github.com/vale981/emacs-ipython-notebook synced 2025-03-04 16:51:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #660 from dickmao/dev

Browse source 
Check symbolp before assuming symbol-name
This commit is contained in:
dickmao 2020-02-09 18:15:47 -05:00 • committed by GitHub
commit 84f367f736
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
README.in.rst
View file

@ -61,7 +61,7 @@ How do I...
... report a bug? ... report a bug?
File an issue using ``M-x ein:dev-bug-report-template``. File an issue using ``M-x ein:dev-bug-report-template``.
First try ``emacs -Q -f package-initialize`` and reproduce the bug. The ``-Q`` skips any user configuration that might interfere with EIN. First try ``emacs -Q -f package-initialize --eval "(setq debug-on-error t)"`` and reproduce the bug. The ``-Q`` skips any user configuration that might interfere with EIN.
Note EIN is tested only for *released* GNU Emacs versions Note EIN is tested only for *released* GNU Emacs versions
.. CI VERSION (see Makefile) .. CI VERSION (see Makefile)

2
README.rst
View file

@ -70,7 +70,7 @@ How do I...
... report a bug? ... report a bug?
File an issue using ``M-x ein:dev-bug-report-template``. File an issue using ``M-x ein:dev-bug-report-template``.
First try ``emacs -Q -f package-initialize`` and reproduce the bug. The ``-Q`` skips any user configuration that might interfere with EIN. First try ``emacs -Q -f package-initialize --eval "(setq debug-on-error t)"`` and reproduce the bug. The ``-Q`` skips any user configuration that might interfere with EIN.
Note EIN is tested only for *released* GNU Emacs versions Note EIN is tested only for *released* GNU Emacs versions
25.1 25.1

4
lisp/ein-worksheet.el
View file

@ -1102,13 +1102,13 @@ If :above or :below specified, execute above/below the current cell."
(lambda (my other) (lambda (my other)
(not (string= (slot-value other 'cell-id) my))) (not (string= (slot-value other 'cell-id) my)))
current-id))) current-id)))
(append (when (and current-id above) (append (when above
(aif (seq-take-while not-matching all) (aif (seq-take-while not-matching all)
it it
(prog1 nil (prog1 nil
(ein:log 'info (ein:log 'info
"ein:worksheet-execute-all-cells: no cells above current")))) "ein:worksheet-execute-all-cells: no cells above current"))))
(when (and current-id below) (when below
(seq-drop-while not-matching all)))) (seq-drop-while not-matching all))))
all))))) all)))))

2
lisp/poly-ein.el
View file

@ -6,7 +6,7 @@
(defmacro poly-ein--remove-hook (label functions) (defmacro poly-ein--remove-hook (label functions)
"Remove any hooks saying LABEL from FUNCTIONS" "Remove any hooks saying LABEL from FUNCTIONS"
`(mapc (lambda (x) (when (cl-search ,label (symbol-name x)) `(mapc (lambda (x) (when (and (symbolp x) (cl-search ,label (symbol-name x)))
(remove-hook (quote ,functions) x t))) (remove-hook (quote ,functions) x t)))
,functions)) ,functions))