hiro/doom-modeline
1
0
Fork 0
mirror of https://github.com/vale981/doom-modeline synced 2025-03-05 09:21:38 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make the icon faces inconsistent.

Browse source 
Fix #306.
1. Remove face: doom-modeline-icon-inactive.
2. Change the face as plist.
This commit is contained in:
Vincent Zhang 2020-02-16 23:03:21 +08:00
parent c2b286f2f3
commit 68e17437cf
2 changed files with 18 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
doom-modeline-core.el
View file

@ -463,11 +463,6 @@ It returns a file name which can be used directly as argument of
"The face used for the left-most bar in the mode-line of an inactive window."
:group 'doom-modeline-faces)
(defface doom-modeline-icon-inactive
`((t (:foreground ,(face-foreground 'mode-line-inactive))))
"The face used for the icon in the mode-line of an inactive window."
:group 'doom-modeline-faces)
(defface doom-modeline-debug-visual
`((t (:background ,(face-foreground 'all-the-icons-orange))))
"Face to use for the mode-line while debugging."
@ -846,7 +841,7 @@ It returns a file name which can be used directly as argument of
;; break them if the font family is set.
;; @see https://github.com/seagle0128/doom-modeline/issues/301
(when (eq face 'mode-line-inactive)
(plist-put args :face 'doom-modeline-icon-inactive))
(plist-put args :face nil))
(pcase icon-set
('octicon

33
doom-modeline-segments.el
View file

@ -359,13 +359,11 @@ mouse-1: Previous buffer\nmouse-3: Next buffer"
(when-let ((icon (or doom-modeline--buffer-file-icon
(doom-modeline-update-buffer-file-icon))))
(concat
(if (doom-modeline--active)
(if doom-modeline-major-mode-color-icon
icon
(propertize icon 'face `(:inherit ,(get-text-property 0 'face icon)
:foreground ,(face-foreground 'mode-line))))
(propertize icon 'face `(:inherit ,(get-text-property 0 'face icon)
:inherit doom-modeline-icon-inactive)))
(if (and (doom-modeline--active) doom-modeline-major-mode-color-icon)
icon
(propertize icon 'face (plist-put
(copy-list (get-text-property 0 'face icon))
:inherit nil)))
(doom-modeline-vspc)))))
(defsubst doom-modeline--buffer-state-icon ()
@ -375,8 +373,9 @@ mouse-1: Previous buffer\nmouse-3: Next buffer"
(concat
(if (doom-modeline--active)
icon
(propertize icon 'face `(:inherit ,(get-text-property 0 'face icon)
:inherit doom-modeline-icon-inactive)))
(propertize icon 'face (plist-put
(copy-list (get-text-property 0 'face icon))
:inherit nil)))
(doom-modeline-vspc)))))
(defsubst doom-modeline--buffer-name ()
@ -654,9 +653,9 @@ Uses `all-the-icons-octicon' to fetch the icon."
(concat
(if active
icon
(propertize icon
'face `(:inherit ,(get-text-property 0 'face icon)
:inherit doom-modeline-icon-inactive)))
(propertize icon 'face (plist-put
(copy-list (get-text-property 0 'face icon))
:inherit nil)))
(doom-modeline-vspc))
'mouse-face 'mode-line-highlight
'help-echo (get-text-property 1 'help-echo vc-mode)
@ -995,8 +994,9 @@ mouse-1: List all problems%s"
(when icon
(if active
icon
(propertize icon 'face `(:inherit ,(get-text-property 0 'face icon)
:inherit doom-modeline-icon-inactive))))
(propertize icon 'face (plist-put
(copy-list (get-text-property 0 'face icon))
:inherit nil))))
(when text
(concat
(doom-modeline-vspc)
@ -1808,8 +1808,9 @@ mouse-1: Start server"))
(doom-modeline-spc)
(if active
icon
(propertize icon 'face `(:inherit ,(get-text-property 0 'face icon)
:foreground ,(face-foreground 'mode-line-inactive))))
(propertize icon 'face (plist-put
(copy-list (get-text-property 0 'face icon))
:inherit nil)))
(doom-modeline-spc))))))
(defun doom-modeline-override-eglot-modeline ()