pylint, oh please.

This commit is contained in:
Andrew Dunai 2018-08-09 14:39:02 +03:00
parent d4c4d2077b
commit 39394144bd
No known key found for this signature in database
GPG key ID: 592B181FC403814E
6 changed files with 7 additions and 15 deletions

View file

@ -4,12 +4,13 @@ max-args = 8
[messages control] [messages control]
disable = disable =
duplicate-code, duplicate-code, # Meh.
too-few-public-methods, too-few-public-methods, # Namespaces are great. (c)
too-many-public-methods, too-many-public-methods, # Namespaces are really great!
too-many-instance-attributes, too-many-instance-attributes, # Ditto.
no-self-use, no-self-use, # Makes code less readable.
too-many-ancestors too-many-ancestors, # Mixins FTW.
useless-object-inheritance # Silly pylint, you forgot Python 2.x!
[miscellaneous] [miscellaneous]

View file

@ -42,7 +42,6 @@ class DebugItem(urwid.AttrMap):
def copy_message(self): def copy_message(self):
"""Copy the selected error message to the clipboard""" """Copy the selected error message to the clipboard"""
copy(self.log_record.formatted_message) copy(self.log_record.formatted_message)
return None
class DebugPage(urwid.Pile, AbstractPage): class DebugPage(urwid.Pile, AbstractPage):

View file

@ -42,7 +42,6 @@ class MyPlaylistListItem(urwid.Columns):
Start playing the selected playlist Start playing the selected playlist
""" """
urwid.emit_signal(self, 'activate', self) urwid.emit_signal(self, 'activate', self)
return None
def get_tracks(self): def get_tracks(self):
""" """

View file

@ -41,7 +41,6 @@ class MyStationListItem(urwid.Columns):
Start playing the selected station Start playing the selected station
""" """
urwid.emit_signal(self, 'activate', self) urwid.emit_signal(self, 'activate', self)
return None
class MyStationListBox(urwid.ListBox): class MyStationListBox(urwid.ListBox):

View file

@ -43,7 +43,6 @@ class SearchBox(urwid.Columns):
Send a message to urwid to search the filled in search query Send a message to urwid to search the filled in search query
""" """
urwid.emit_signal(self, 'search-requested', self.query.edit_text) urwid.emit_signal(self, 'search-requested', self.query.edit_text)
return None
class SearchPage(urwid.Pile, AbstractPage): class SearchPage(urwid.Pile, AbstractPage):
@ -109,6 +108,5 @@ class SearchPage(urwid.Pile, AbstractPage):
self.focus_position = 2 self.focus_position = 2
else: else:
self.focus_position = 0 self.focus_position = 0
return None
else: else:
return super(SearchPage, self).keypress(size, key) return super(SearchPage, self).keypress(size, key)

View file

@ -91,8 +91,6 @@ class Slider(urwid.Widget):
self.value += 1 self.value += 1
self.update() self.update()
return None
def equalizer_down(self): def equalizer_down(self):
""" """
Turn the equalizer band down Turn the equalizer band down
@ -101,8 +99,6 @@ class Slider(urwid.Widget):
self.value -= 1 self.value -= 1
self.update() self.update()
return None
def update(self): def update(self):
""" """
Update player equalizer & toggle redraw. Update player equalizer & toggle redraw.