From 226ed94603f5463c24a9d04e1a7222a8f66f4cde Mon Sep 17 00:00:00 2001
From: Pascal <molin.maths@gmail.com>
Date: Sun, 29 Oct 2017 18:24:45 +0100
Subject: [PATCH] order arguments in acb_vec_unit_roots

---
 acb.h                       | 2 +-
 acb/test/t-vec_unit_roots.c | 2 +-
 acb/vec_unit_roots.c        | 2 +-
 acb_dft/bluestein.c         | 2 +-
 acb_dft/cyc.c               | 2 +-
 acb_dft/naive.c             | 4 ++--
 acb_dft/rad2.c              | 2 +-
 doc/source/acb.rst          | 2 +-
 8 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/acb.h b/acb.h
index add4d3bc..65837965 100644
--- a/acb.h
+++ b/acb.h
@@ -1142,7 +1142,7 @@ void _acb_vec_sort_pretty(acb_ptr vec, slong len);
 
 /* roots of unity */
 void acb_unit_root(acb_t res, ulong order, slong prec);
-void _acb_vec_unit_roots(acb_ptr z, slong len, slong order, slong prec);
+void _acb_vec_unit_roots(acb_ptr z, slong order, slong len, slong prec);
 
 ACB_INLINE slong
 acb_allocated_bytes(const acb_t x)
diff --git a/acb/test/t-vec_unit_roots.c b/acb/test/t-vec_unit_roots.c
index b623fd71..239b07b1 100644
--- a/acb/test/t-vec_unit_roots.c
+++ b/acb/test/t-vec_unit_roots.c
@@ -51,7 +51,7 @@ int main()
             acb_init(t);
             fmpq_init(q);
 
-            _acb_vec_unit_roots(vec, len, order, prec);
+            _acb_vec_unit_roots(vec, order, len, prec);
 
             for (k = 0; k < len; k++)
             {
diff --git a/acb/vec_unit_roots.c b/acb/vec_unit_roots.c
index ae891c45..752e3f39 100644
--- a/acb/vec_unit_roots.c
+++ b/acb/vec_unit_roots.c
@@ -13,7 +13,7 @@
 #include "acb.h"
 
 void
-_acb_vec_unit_roots(acb_ptr res, slong len, slong n, slong prec)
+_acb_vec_unit_roots(acb_ptr res, slong n, slong len, slong prec)
 {
     int conj = 0;
     slong k, len1, wp;
diff --git a/acb_dft/bluestein.c b/acb_dft/bluestein.c
index 71197919..6849c518 100644
--- a/acb_dft/bluestein.c
+++ b/acb_dft/bluestein.c
@@ -26,7 +26,7 @@ _acb_vec_bluestein_factors(acb_ptr z, slong n, slong prec)
         nmod_t n2;
 
         z2n = _acb_vec_init(2 * n);
-        _acb_vec_unit_roots(z2n, 2 * n, -2 * n, prec);
+        _acb_vec_unit_roots(z2n, -2 * n, 2 * n, prec);
         nmod_init(&n2, 2 * n);
 
         for (k = 0, k2 = 0; k < n; k++)
diff --git a/acb_dft/cyc.c b/acb_dft/cyc.c
index 3195f218..68b8eea5 100644
--- a/acb_dft/cyc.c
+++ b/acb_dft/cyc.c
@@ -27,7 +27,7 @@ _acb_dft_cyc_init_z_fac(acb_dft_cyc_t t, n_factor_t fac, slong dv, acb_ptr z, sl
         if (DFT_VERB)
             flint_printf("dft_cyc: init z[%wu]\n", t->n);
         z = _acb_vec_init(t->n);
-        _acb_vec_unit_roots(z, t->n, -t->n, prec);
+        _acb_vec_unit_roots(z, -t->n, t->n, prec);
         dz = 1;
         t->zclear = 1;
     }
diff --git a/acb_dft/naive.c b/acb_dft/naive.c
index 9dabe1a6..20dd382a 100644
--- a/acb_dft/naive.c
+++ b/acb_dft/naive.c
@@ -57,7 +57,7 @@ acb_dft_naive(acb_ptr w, acb_srcptr v, slong len, slong prec)
     acb_ptr z, v1 = NULL;
 
     z = _acb_vec_init(len);
-    _acb_vec_unit_roots(z, len, -len, prec);
+    _acb_vec_unit_roots(z, -len, len, prec);
     if (w == v)
     {
         v1 = _acb_vec_init(len);
@@ -84,7 +84,7 @@ _acb_dft_naive_init(acb_dft_naive_t pol, slong dv, acb_ptr z, slong dz, slong le
         if (DFT_VERB)
             flint_printf("dft_naive: init z[%ld]\n",len);
         pol->z = _acb_vec_init(len);
-        _acb_vec_unit_roots(pol->z, len, -len, prec);
+        _acb_vec_unit_roots(pol->z, -len, len, prec);
         pol->dz = 1;
         pol->zclear = 1;
     }
diff --git a/acb_dft/rad2.c b/acb_dft/rad2.c
index e25670bf..223918a7 100644
--- a/acb_dft/rad2.c
+++ b/acb_dft/rad2.c
@@ -50,7 +50,7 @@ _acb_dft_rad2_init(acb_dft_rad2_t t, slong dv, int e, slong prec)
     t->nz = t->n >> 1;
     t->z = _acb_vec_init(t->nz);
     /* set n/2 roots of order n */
-    _acb_vec_unit_roots(t->z, t->nz, -t->n, prec);
+    _acb_vec_unit_roots(t->z, -t->n, t->nz, prec);
 }
 
 /* remark: can use same rad2 with smaller power of 2 */
diff --git a/doc/source/acb.rst b/doc/source/acb.rst
index 1f567d84..8e07bd0e 100644
--- a/doc/source/acb.rst
+++ b/doc/source/acb.rst
@@ -1026,7 +1026,7 @@ Vector functions
 
     Sets *xs* to the powers `1, x, x^2, \ldots, x^{len-1}`.
 
-.. function:: void _acb_vec_unit_roots(acb_ptr z, slong len, slong order, slong prec)
+.. function:: void _acb_vec_unit_roots(acb_ptr z, slong order, slong len, slong prec)
 
     Sets *z* to the powers `1,z,z^2,\dots z^{\mathrm{len}-1}` where `z=\exp(\frac{2i\pi}{\mathrm{order}})` to precision *prec*.
     *order* can be taken negative.