I'm reverting apollographql/apollo-server#1698 not because it's been problematic in any way, but because I'd like to give it a bit more thought and don't want this to accidentally get cut into a release prior to that consideration.
More specifically: The `graphql-tools` update on its own shouldn't really cause any problems, but the [4.x version of `graphql-tools`](https://github.com/apollographql/graphql-tools/releases/tag/4.0.0) is intended to support and enable the latest `graphql@14` which contains [breaking changes](https://github.com/graphql/graphql-js/releases/tag/v14.0.0).
I believe most of those breaking changes would be show-stoppers and the failures would surface immediately (meaning that servers would completely fail to start, rather than being a surprise in other, more delayed scenarios), but it's still worth pausing and carefully considering versioning to avoid any surprises.
That said, the 14.x version of `graphql` has been an acceptable range in the `peerDependencies` of `apollo-server-*` since before its final release came out, and I don't believe we've caught wind of anything that a major version bump would have prevented or made more clear. In the end, `graphql` is a peer dependency and any problems should only surface if consumers also update their `graphql` dependency — a clear major version bump, which deserves review by the upgrader — so perhaps we can avoid bumping the major version after all?
Input welcomed, but again, merging this now to give this a bit more thought first.
cc @hwillson
* Switch to a fork of `apollo-upload-server` to fix missing `core-js` dependency.
As reported in https://github.com/apollographql/apollo-server/issues/1542,
the `apollo-upload-server` package (v5.0.0, which `apollo-server` relies on)
is no longer able to provide a `core-js` package because of change that was
outside of its control in a Babel release.
The problem is resolved in newer versions of `apollo-upload-server`,
however, regrettably, the newer versions of that package (notably, v6 and
v7) drop support for Node.js 6 — one of two versions of Node.js that are
currently under the terms of the Node.js Foundation's Long-Term-Support
(LTS) agreements.
Since Apollo Server aims to support versions of Node.js which are under LTS
(and will drop support for Node.js 6 in April 2019, per Node.js' schedule)
the current, immediate solution is to fork the `apollo-upload-server`
package as `@apollographql/apollo-upload-server`.
With the inclusion of
https://github.com/apollographql/apollo-upload-server/pull/1, we are able to
keep supporting Node.js 6. Without this change, every new installation
of `apollo-server`, which doesn't have a `package-lock.json` preventing
transitive dependency updates - specifically, the updates to
`@babel/runtime` versions newer than `-beta.56` - is broken.
* [squash] Update to `@apollographql/apollo-upload-server@5.0.2`.
* [squash] Update to `@apollographql/apollo-upload-server@5.0.3`.
* Export polyfills and types separately
* More imports from apollo-server-env
* Initial commit
* Add .npmignore to avoid ignoring lib when publishing
* 0.0.2
* Reorganize code and clean up GraphQLExtension interface
* 0.0.3
* Add support for timing callbacks and add GraphQLExtensionStack
* 0.0.4
* Downgrade target in tsconfig.json from es2015 to es5
* 0.0.5
* Bump `graphql` peerDependency. (#3)
* 0.0.6
* Update dependencies
* 0.0.7
* whenResultIsFinished fix for array results (#4)
* 0.0.8
* [apollo-bot] Update the Issue/PR Templates with auto label (#6)
* Bump `graphql` peerDependency. (#7)
* Update `graphql` peer dependency range to allow 0.13.x. (#8)
* Update `devDependencies` to latest versions. (#9)
* dev: Update TypeScript to latest version, v2.7.2.
* dev: Update `graphql` to latest version, v0.13.2.
* dev: Update jest & dependencies to latest versions.
* dev: Update type definitions for `graphql`, `node` and `jest`.
* Allow `undefined` return values to `GraphQLExtension`'s `format()`. (#10)
In some cases, it's conceivable that the `format()` method may need to abort
its decision to provide extension information at runtime, in the event that
it doesn't have the proper information to return a full-result.
The `format` method already removed false-y results, so this simply changes
the types to allow the same.
* 0.0.9
* Fix lifecycle method invocations on extensions
* 0.0.10
* Add changelog
* Upgrade to TypeScript 2.8
Makes my editor integration happier (a bugfix in tsserver I think)
* Add tslint and prettier
Same configuration as apollo-engine-js
* Remove magic from GraphQLExtensionStack constructor
It's not hard to consistently pass in an actual extension object to this
low-level API.
* New extension API: didStart handlers return didEnd handlers
This is a backwards-incompatible change: GraphQLExtension implementations and
users of GraphQLExtensionStack (ie apollo-server-core) must change their
implementations, if they implement any of the xDidStart/xDidEnd APIs.
This allows "didEnd" handlers to refer to closure variables from the "didStart"
handler rather than needing to store state on the extension.
The new "didEnd" handlers run in the opposite order of the "didStart" handlers,
so that they properly nest.
* 0.1.0-beta.0
* Changelog
* Add magic back into GraphQLExtensionStack constructor
But now it actually gets more context (the execution arguments) and doesn't have
to be a constructor.
* 0.1.0-beta.1
* Export more types
* 0.1.0-beta.2
* Fix lifecycle handlers to pass proper "this"
* 0.1.0-beta.3
* Pass options directly to start handlers; eliminate factory again
* 0.1.0-beta.4
* error handling in didEnd
* 0.1.0-beta.5
* pass multiple errors to EndHandler
* 0.1.0-beta.6
* add willSendResponse
* 0.1.0-beta.7
* prettier
* setFieldResolver for custom fieldResolver
* reverse
* get more initial options into requestDidStart
* 0.1.0-beta.8
* 0.1.0-beta.9
* Actually, we already get the fieldResolver!
* 0.1.0-beta.10
* work without extensionStack
* 0.1.0-beta.11
* 0.1.0-beta.12
* Send errors to willResolveField callback
* 0.1.0-beta.13
* willSendResponse can return a result
* 0.1.0-beta.14
* Revert 1063be8..56912fc
This reverts commit 1063be8..56912fc.
* add PQ options to requestDidStart
* 0.1.0-beta.14
* 0.1.0-beta.15
* Initialize an empty TypeScript/Jest package
Template based on apollo-engine-js
* Basic trace node structure building
* basic timing
* Checkpoint towards signature implementation
The new signature implementation does not try to compress whitespace.
* Basic signature implementation
* progress towards actual reporting
* basic checkpoint for reporting
* 0.0.0-beta.1
* pull in @types/long, since it is in the external api
* 0.0.0-beta.2
* get rid of Long
* 0.0.0-beta.3
* debug log request what happened
* 0.0.0-beta.4
* 0.0.0-beta.5
* correct url
* 0.0.0-beta.6
* request headers
* 0.0.0-beta.7
* leave out a few headers
* 0.0.0-beta.8
* prettier
* move stuff into multiple files, and stop exporting the extension
* lots of doc comments
* address agent.ts XXX comments
* implement privateVariables
simplify API by removing flush() and allowing flush-ers to just call sendReport
directly
* privateHeaders and error tracking
* gzip, signals
* fix test
* 0.0.0-beta.9
* Error handling for reports
* 0.0.0-beta.10
* no need to include boring stacktrace
* 0.0.0-beta.11
* tweak error reporting
* 0.0.0-beta.12
* package-lock update (npm@6?)
* Reduce target report size to 512KB from 4MB.
Load testing revealed that protobuf encoding for large FullTraceReports could
tie up CPU and reduce p99 request latency (eg, to 200ms from 10ms). Reducing the
default target report size spreads out the encoding time and mitigates the
impact on latency. If this is not acceptable for all users, we may have to
investigate reintroducing agent-side stats aggregation to keep report sizes
small.
* 0.0.0-beta.13
* Encode Traces as they come in
This improves p99 times with little effect on p50 times. It also lets us get rid
of the heuristic average trace size estimation.
* 0.0.0-beta.14
* support PQ fields
* npm audit fix
* 0.0.0-beta.15
* ignore coverage
* Make the default signature more aggressive
We'd rather tell people confused by literal removal to tweak the signature than
tell people causing outages to do so.
* 0.0.0-beta.16
* Remove obsolete files from graphql-extensions and apollo-engine-reporting
* Fix dependencies and configs
* Fix apollo-server-cloudflare to import from apollo-server-env
* Fix compilation and test configs
* Get all tests passing again
* Switch to Lerna independent versioning
* Polyfill promisify for Node < 8 and load polyfills in tests
* ES2016 exponentiation operator is only supported in Node > 6
* add dependency cache for circle
* add missing env dependencies in REST datasource
