The techniques previously used to skip particular tests for particular
Node.js versions (for example, file uploads, Hapi, etc.) were problematic in
a couple ways:
1. `return`-ing outside a function (say, at the top level of a module) is
not valid ECMAScript. While it works in this current state, it only works
because of Babel's wrapping scope. As we move toward less and less
transpiled modules, this would become problematic anyway, but it's a
short-term blocker for me since I intend on dropping the `skipBabel` option
we currently pass to` `ts-jest` in its current (`package.json`)
configuration. (My editor also dislikes top-level `return`, expectedly.)
2. By `return`-ing from a test which we wish to skip conditionally, we avoid
the awareness which is provided by Jest (automatically) when using its
built-in `.skip` helpers. By switching to technique I've employed here,
we're able to see `<num> skipped` in Jest's output and (rightfully) be able
to question why something is being skipped.
By using the `atLeastMajorNodeVersion` helper, we'll also be able to more
easily find where this pattern is used in test-cases, to more easily
re-evaluate their use-cases when we add support newer Node.js versions.
`esModuleInterop` was enabled in
e4164c8892
to help with importing from packages that use default exports.
Those changes were reverted in
https://github.com/apollographql/apollo-server/pull/1210
to work around a few reported issues. Those issues are no longer
relevant, so this commit re-enables `esModuleInterop`, and
updates all default imports to use the more common (standard)
import syntax.
* Allow an optional function to resolve the rootValue
Passes the parsed DocumentNode AST to determine the root value,
useful when providing a different rootValue for query vs mutation
* Add API docs for rootValue
* Pass the context along to all the extension methods
Addresses #1343
With this change you should now be able to implement an extension like so:
```javascript
class MyErrorTrackingExtension extends GraphQLExtension {
willSendResponse(o) {
const { context, graphqlResponse } = o
context.trackErrors(graphqlResponse.errors)
return o
}
}
```
Edit by @evans :
fixes#1343fixes#614 as the request object can be taken from context or from requestDidStart
fixes#631 ""
* Remove context from extra extension functions
The context shouldn't be necessary for format, parse, validation, and
execute. Format generally outputs the state of the extension. Parse and
validate don't depend on the context. Execution includes the context
argument as contextValue
* Move change entry under vNext
* Remove Node dependencies from package.json
* Replace Node request with fetch
* Wrap fetch in @zeit/fetch-retry, convert to async/await, and fix types
* Use async-retry directly because @zeit/fetch-retry doesn't support Node 6
* bump server-env version in graphql-extensions
* explicitly include factor in async-retry
* change apollo-server-env to rc.5
* enable willSendResponse to return a modified response
* add formatError as an extension that wraps engine reporting
* ensure that formatError once on every error path
* move old formatError express tests into integration suite
* add error lifecycle with minimal engine reporting check
* increase granularity of formatError test
* return 400 error for GraphQL error created by context
* add check for internal server error for errors thrown in context
* comment about context error status code
* Export polyfills and types separately
* More imports from apollo-server-env
* Initial commit
* Add .npmignore to avoid ignoring lib when publishing
* 0.0.2
* Reorganize code and clean up GraphQLExtension interface
* 0.0.3
* Add support for timing callbacks and add GraphQLExtensionStack
* 0.0.4
* Downgrade target in tsconfig.json from es2015 to es5
* 0.0.5
* Bump `graphql` peerDependency. (#3)
* 0.0.6
* Update dependencies
* 0.0.7
* whenResultIsFinished fix for array results (#4)
* 0.0.8
* [apollo-bot] Update the Issue/PR Templates with auto label (#6)
* Bump `graphql` peerDependency. (#7)
* Update `graphql` peer dependency range to allow 0.13.x. (#8)
* Update `devDependencies` to latest versions. (#9)
* dev: Update TypeScript to latest version, v2.7.2.
* dev: Update `graphql` to latest version, v0.13.2.
* dev: Update jest & dependencies to latest versions.
* dev: Update type definitions for `graphql`, `node` and `jest`.
* Allow `undefined` return values to `GraphQLExtension`'s `format()`. (#10)
In some cases, it's conceivable that the `format()` method may need to abort
its decision to provide extension information at runtime, in the event that
it doesn't have the proper information to return a full-result.
The `format` method already removed false-y results, so this simply changes
the types to allow the same.
* 0.0.9
* Fix lifecycle method invocations on extensions
* 0.0.10
* Add changelog
* Upgrade to TypeScript 2.8
Makes my editor integration happier (a bugfix in tsserver I think)
* Add tslint and prettier
Same configuration as apollo-engine-js
* Remove magic from GraphQLExtensionStack constructor
It's not hard to consistently pass in an actual extension object to this
low-level API.
* New extension API: didStart handlers return didEnd handlers
This is a backwards-incompatible change: GraphQLExtension implementations and
users of GraphQLExtensionStack (ie apollo-server-core) must change their
implementations, if they implement any of the xDidStart/xDidEnd APIs.
This allows "didEnd" handlers to refer to closure variables from the "didStart"
handler rather than needing to store state on the extension.
The new "didEnd" handlers run in the opposite order of the "didStart" handlers,
so that they properly nest.
* 0.1.0-beta.0
* Changelog
* Add magic back into GraphQLExtensionStack constructor
But now it actually gets more context (the execution arguments) and doesn't have
to be a constructor.
* 0.1.0-beta.1
* Export more types
* 0.1.0-beta.2
* Fix lifecycle handlers to pass proper "this"
* 0.1.0-beta.3
* Pass options directly to start handlers; eliminate factory again
* 0.1.0-beta.4
* error handling in didEnd
* 0.1.0-beta.5
* pass multiple errors to EndHandler
* 0.1.0-beta.6
* add willSendResponse
* 0.1.0-beta.7
* prettier
* setFieldResolver for custom fieldResolver
* reverse
* get more initial options into requestDidStart
* 0.1.0-beta.8
* 0.1.0-beta.9
* Actually, we already get the fieldResolver!
* 0.1.0-beta.10
* work without extensionStack
* 0.1.0-beta.11
* 0.1.0-beta.12
* Send errors to willResolveField callback
* 0.1.0-beta.13
* willSendResponse can return a result
* 0.1.0-beta.14
* Revert 1063be8..56912fc
This reverts commit 1063be8..56912fc.
* add PQ options to requestDidStart
* 0.1.0-beta.14
* 0.1.0-beta.15
* Initialize an empty TypeScript/Jest package
Template based on apollo-engine-js
* Basic trace node structure building
* basic timing
* Checkpoint towards signature implementation
The new signature implementation does not try to compress whitespace.
* Basic signature implementation
* progress towards actual reporting
* basic checkpoint for reporting
* 0.0.0-beta.1
* pull in @types/long, since it is in the external api
* 0.0.0-beta.2
* get rid of Long
* 0.0.0-beta.3
* debug log request what happened
* 0.0.0-beta.4
* 0.0.0-beta.5
* correct url
* 0.0.0-beta.6
* request headers
* 0.0.0-beta.7
* leave out a few headers
* 0.0.0-beta.8
* prettier
* move stuff into multiple files, and stop exporting the extension
* lots of doc comments
* address agent.ts XXX comments
* implement privateVariables
simplify API by removing flush() and allowing flush-ers to just call sendReport
directly
* privateHeaders and error tracking
* gzip, signals
* fix test
* 0.0.0-beta.9
* Error handling for reports
* 0.0.0-beta.10
* no need to include boring stacktrace
* 0.0.0-beta.11
* tweak error reporting
* 0.0.0-beta.12
* package-lock update (npm@6?)
* Reduce target report size to 512KB from 4MB.
Load testing revealed that protobuf encoding for large FullTraceReports could
tie up CPU and reduce p99 request latency (eg, to 200ms from 10ms). Reducing the
default target report size spreads out the encoding time and mitigates the
impact on latency. If this is not acceptable for all users, we may have to
investigate reintroducing agent-side stats aggregation to keep report sizes
small.
* 0.0.0-beta.13
* Encode Traces as they come in
This improves p99 times with little effect on p50 times. It also lets us get rid
of the heuristic average trace size estimation.
* 0.0.0-beta.14
* support PQ fields
* npm audit fix
* 0.0.0-beta.15
* ignore coverage
* Make the default signature more aggressive
We'd rather tell people confused by literal removal to tweak the signature than
tell people causing outages to do so.
* 0.0.0-beta.16
* Remove obsolete files from graphql-extensions and apollo-engine-reporting
* Fix dependencies and configs
* Fix apollo-server-cloudflare to import from apollo-server-env
* Fix compilation and test configs
* Get all tests passing again
* Switch to Lerna independent versioning
* Polyfill promisify for Node < 8 and load polyfills in tests
* ES2016 exponentiation operator is only supported in Node > 6
* add dependency cache for circle
* add missing env dependencies in REST datasource
* ensure that formatError receives instanceof Error
* add formatError test for instanceof
* apply Martijn's feedback to usse Object.create 🎉
* check constructor name inside of formatError
* core: return response object from runHttpQuery
* core: change gqlResponse to graphqlResponse and add custom RequestInit type
* core: add cache-control headers based on the calcualted maxAge
* core: add extensions check during cache-control header creation
* core: create headers when cacheControl is not enabled otherwise pass through extensions
* express: initial tests of CDN cach-contol headers
* core: fixed tests with applyMiddleware and pass cacheControl config
* core: cache hint fixes, ignore when no maxAge, and check for rootKeys
* core: check for hints of length 0
* core: node 10 fails file upload test for some stream reason
* docs: add cdn caching section to features
* add space after // in comments
* fix feedback: proxy alignment and response creation
Adds cache-control toggles for http header calculation and stripping out
the cache control extensions from the respose.
Brings the default calculation of headers in line with the proxy.
* fix links in comments
* fix tests with null dereference
* update cdn docs and migration guide to include latest cdn configuration
* add not for engine migration to set engine to false
* add engine set to false in migration guide
* express: fixed tests
* address feedback to use omit and documentation
* docs: cdn caching is alternative to full response caching
* add back epipe check in upload tests
