This should hopefully make it easier to quickly identify failing tests
within the CircleCI interface since CircleCI will be able to
programmatically consume the test results.
Hopefully this will act as reminder for the future. I've used `NODE` here
as a sort of `TODO` so other references in the codebase might be more easily
located.
Not only did removing this configuration reveal invalid JavaScript code, it
also fixes the source mapping for the coverage reports so that they report
the coverage details based on the original file rather than the `tsc`
compiled output (JavaScript).
Ref: c9375c405b (invalid top-level `return`)
* Export polyfills and types separately
* More imports from apollo-server-env
* Initial commit
* Add .npmignore to avoid ignoring lib when publishing
* 0.0.2
* Reorganize code and clean up GraphQLExtension interface
* 0.0.3
* Add support for timing callbacks and add GraphQLExtensionStack
* 0.0.4
* Downgrade target in tsconfig.json from es2015 to es5
* 0.0.5
* Bump `graphql` peerDependency. (#3)
* 0.0.6
* Update dependencies
* 0.0.7
* whenResultIsFinished fix for array results (#4)
* 0.0.8
* [apollo-bot] Update the Issue/PR Templates with auto label (#6)
* Bump `graphql` peerDependency. (#7)
* Update `graphql` peer dependency range to allow 0.13.x. (#8)
* Update `devDependencies` to latest versions. (#9)
* dev: Update TypeScript to latest version, v2.7.2.
* dev: Update `graphql` to latest version, v0.13.2.
* dev: Update jest & dependencies to latest versions.
* dev: Update type definitions for `graphql`, `node` and `jest`.
* Allow `undefined` return values to `GraphQLExtension`'s `format()`. (#10)
In some cases, it's conceivable that the `format()` method may need to abort
its decision to provide extension information at runtime, in the event that
it doesn't have the proper information to return a full-result.
The `format` method already removed false-y results, so this simply changes
the types to allow the same.
* 0.0.9
* Fix lifecycle method invocations on extensions
* 0.0.10
* Add changelog
* Upgrade to TypeScript 2.8
Makes my editor integration happier (a bugfix in tsserver I think)
* Add tslint and prettier
Same configuration as apollo-engine-js
* Remove magic from GraphQLExtensionStack constructor
It's not hard to consistently pass in an actual extension object to this
low-level API.
* New extension API: didStart handlers return didEnd handlers
This is a backwards-incompatible change: GraphQLExtension implementations and
users of GraphQLExtensionStack (ie apollo-server-core) must change their
implementations, if they implement any of the xDidStart/xDidEnd APIs.
This allows "didEnd" handlers to refer to closure variables from the "didStart"
handler rather than needing to store state on the extension.
The new "didEnd" handlers run in the opposite order of the "didStart" handlers,
so that they properly nest.
* 0.1.0-beta.0
* Changelog
* Add magic back into GraphQLExtensionStack constructor
But now it actually gets more context (the execution arguments) and doesn't have
to be a constructor.
* 0.1.0-beta.1
* Export more types
* 0.1.0-beta.2
* Fix lifecycle handlers to pass proper "this"
* 0.1.0-beta.3
* Pass options directly to start handlers; eliminate factory again
* 0.1.0-beta.4
* error handling in didEnd
* 0.1.0-beta.5
* pass multiple errors to EndHandler
* 0.1.0-beta.6
* add willSendResponse
* 0.1.0-beta.7
* prettier
* setFieldResolver for custom fieldResolver
* reverse
* get more initial options into requestDidStart
* 0.1.0-beta.8
* 0.1.0-beta.9
* Actually, we already get the fieldResolver!
* 0.1.0-beta.10
* work without extensionStack
* 0.1.0-beta.11
* 0.1.0-beta.12
* Send errors to willResolveField callback
* 0.1.0-beta.13
* willSendResponse can return a result
* 0.1.0-beta.14
* Revert 1063be8..56912fc
This reverts commit 1063be8..56912fc.
* add PQ options to requestDidStart
* 0.1.0-beta.14
* 0.1.0-beta.15
* Initialize an empty TypeScript/Jest package
Template based on apollo-engine-js
* Basic trace node structure building
* basic timing
* Checkpoint towards signature implementation
The new signature implementation does not try to compress whitespace.
* Basic signature implementation
* progress towards actual reporting
* basic checkpoint for reporting
* 0.0.0-beta.1
* pull in @types/long, since it is in the external api
* 0.0.0-beta.2
* get rid of Long
* 0.0.0-beta.3
* debug log request what happened
* 0.0.0-beta.4
* 0.0.0-beta.5
* correct url
* 0.0.0-beta.6
* request headers
* 0.0.0-beta.7
* leave out a few headers
* 0.0.0-beta.8
* prettier
* move stuff into multiple files, and stop exporting the extension
* lots of doc comments
* address agent.ts XXX comments
* implement privateVariables
simplify API by removing flush() and allowing flush-ers to just call sendReport
directly
* privateHeaders and error tracking
* gzip, signals
* fix test
* 0.0.0-beta.9
* Error handling for reports
* 0.0.0-beta.10
* no need to include boring stacktrace
* 0.0.0-beta.11
* tweak error reporting
* 0.0.0-beta.12
* package-lock update (npm@6?)
* Reduce target report size to 512KB from 4MB.
Load testing revealed that protobuf encoding for large FullTraceReports could
tie up CPU and reduce p99 request latency (eg, to 200ms from 10ms). Reducing the
default target report size spreads out the encoding time and mitigates the
impact on latency. If this is not acceptable for all users, we may have to
investigate reintroducing agent-side stats aggregation to keep report sizes
small.
* 0.0.0-beta.13
* Encode Traces as they come in
This improves p99 times with little effect on p50 times. It also lets us get rid
of the heuristic average trace size estimation.
* 0.0.0-beta.14
* support PQ fields
* npm audit fix
* 0.0.0-beta.15
* ignore coverage
* Make the default signature more aggressive
We'd rather tell people confused by literal removal to tweak the signature than
tell people causing outages to do so.
* 0.0.0-beta.16
* Remove obsolete files from graphql-extensions and apollo-engine-reporting
* Fix dependencies and configs
* Fix apollo-server-cloudflare to import from apollo-server-env
* Fix compilation and test configs
* Get all tests passing again
* Switch to Lerna independent versioning
* Polyfill promisify for Node < 8 and load polyfills in tests
* ES2016 exponentiation operator is only supported in Node > 6
* add dependency cache for circle
* add missing env dependencies in REST datasource
Since f0f75b183e93cc91d31255e7ffd60c1de5d4f16e, it seems important to
restore the reasoning for the usage of `yarn` to avoid confusion in the
future. This comment was originally removed in 301e144d23.
This reverts the comment from that commit and further improves the clarity.
Ref: https://github.com/apollographql/apollo-server/commit/301e144d#r29319011
npm 6 deprecates support for Node.js 4, which is still LTS until the end of
the week.
It's probably best to take a moment and ensure that npm@6 is actually
working as we desire too, so this is just to make sure that we don't end up
with a bunch of PRs that need to be re-based/re-tested, which seems to
already be happening.
This should avoid needing to include `[skip ci]` on every commit on branches
which are committed to docs, though will still provide us one "master"
branch run of tests when the PR lands.
We may want to remove this (maybe? longer-term), but this seems like a
short-term "win" on this branch for the time being.
cc: @jbaxleyiii @evans
By using CircleCI 2.0's new Workflow feature, we can more delicately
orchestrate how the test suite runs.
Specifically, we can have individual groups of tests report their status
independently to pull-requests, and react accordingly. For example, rather
than the linting tests being lumped into the individual tests ran on each
Node.js platform version, we can now run them on their own (and also avoid
unnecessarily running them over and over again for each Node.js version!).
Each jobs test results will be reported to the pull-request directly and, if
desired, the repository's branch merge rules can be modified to allow specific
types of test failures (like linting) to be allowed.
This need for greater test granularity became quite relevant recently when many
of the outstanding PRs on this repository were failing because of "prettier"
failures which were not directly related to the files changed by the PR but
by other changes on the `master` branch. In order to confidently review and
merge those PRs, it was necessary to look through each PRs four platform
test runs and ensure _each_ was a prettier failure and not something more
substantial. This manual step left way too much room for error and was not
a confidence builder, at all!
I've also added a new test for the documentation generation to ensure that
no changes in the PR have caused the documentation to not generate, which
would result in stale documentation since the existing documentation would
simply remain in place until the problem was eventually noticed.
As a last benefit, in my observations so far, CircleCI is running more
tests, more quickly and with greater parallelisation than our previous test
provider. Recently I've seen tests finishing in about two minutes rather than
what was sometimes 5 minutes.
