hiro/apollo-server
1
0
Fork 0
mirror of https://github.com/vale981/apollo-server synced 2025-03-04 17:21:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Move tests for context types from apollo-server into integration testsuite (#2363)

Browse source 
* refactor: move tests for context function added in apollo-server into integration test suite

* Move existing context tests in integration testsuite into `describe('context field'`

# Conflicts:
#	packages/apollo-server-integration-testsuite/src/ApolloServer.ts

* Add back tests in apollo-server along with comments to explain the duplication
This commit is contained in:
Chang Wang 2019-02-27 06:30:56 -05:00 • committed by Jesse Rosenberger
parent 0b14a3f1ff
commit f8fc1e1922
2 changed files with 170 additions and 108 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

116
packages/apollo-server-integration-testsuite/src/ApolloServer.ts
View file

@ -690,6 +690,19 @@ export function testApolloServer<AS extends ApolloServerBase>(
expect(formatError).toHaveBeenCalledTimes(1);
});
describe('context field', () => {
const typeDefs = gql`
type Query {
hello: String
}
`;
const resolvers = {
Query: {
hello: () => 'hi',
},
};
it('defers context eval with thunk until after options creation', async () => {
const uniqueContext = { key: 'major' };
const typeDefs = gql`
@ -722,35 +735,6 @@ export function testApolloServer<AS extends ApolloServerBase>(
expect(spy).toHaveBeenCalledTimes(2);
});
it('allows context to be async function', async () => {
const uniqueContext = { key: 'major' };
const spy = jest.fn(() => 'hi');
const typeDefs = gql`
type Query {
hello: String
}
`;
const resolvers = {
Query: {
hello: (_parent, _args, context) => {
expect(context.key).toEqual('major');
return spy();
},
},
};
const { url: uri } = await createApolloServer({
typeDefs,
resolvers,
context: async () => uniqueContext,
});
const apolloFetch = createApolloFetch({ uri });
expect(spy).not.toBeCalled();
await apolloFetch({ query: '{hello}' });
expect(spy).toHaveBeenCalledTimes(1);
});
it('clones the context for every request', async () => {
const uniqueContext = { key: 'major' };
const spy = jest.fn(() => 'hi');
@ -784,6 +768,56 @@ export function testApolloServer<AS extends ApolloServerBase>(
expect(spy).toHaveBeenCalledTimes(2);
});
describe('as a function', () => {
it('can accept and return `req`', async () => {
expect(
await createApolloServer({
typeDefs,
resolvers,
context: ({ req }) => ({ req }),
}),
).not.toThrow;
});
it('can accept nothing and return an empty object', async () => {
expect(
await createApolloServer({
typeDefs,
resolvers,
context: () => ({}),
}),
).not.toThrow;
});
it('can be an async function', async () => {
const uniqueContext = { key: 'major' };
const spy = jest.fn(() => 'hi');
const typeDefs = gql`
type Query {
hello: String
}
`;
const resolvers = {
Query: {
hello: (_parent, _args, context) => {
expect(context.key).toEqual('major');
return spy();
},
},
};
const { url: uri } = await createApolloServer({
typeDefs,
resolvers,
context: async () => uniqueContext,
});
const apolloFetch = createApolloFetch({ uri });
expect(spy).not.toBeCalled();
await apolloFetch({ query: '{hello}' });
expect(spy).toHaveBeenCalledTimes(1);
});
it('returns thrown context error as a valid graphql result', async () => {
const nodeEnv = process.env.NODE_ENV;
delete process.env.NODE_ENV;
@ -821,6 +855,30 @@ export function testApolloServer<AS extends ApolloServerBase>(
process.env.NODE_ENV = nodeEnv;
});
});
describe('as an object', () => {
it('can be an empty object', async () => {
expect(
await createApolloServer({
typeDefs,
resolvers,
context: {},
}),
).not.toThrow;
});
it('can contain arbitrary values', async () => {
expect(
await createApolloServer({
typeDefs,
resolvers,
context: { value: 'arbitrary' },
}),
).not.toThrow;
});
});
});
it('propogates error codes in production', async () => {
const nodeEnv = process.env.NODE_ENV;

4
packages/apollo-server/src/__tests__/index.test.ts
View file

@ -25,6 +25,10 @@ describe('apollo-server', () => {
expect(() => new ApolloServer({ typeDefs, mocks: true })).not.toThrow;
});
// These tests are duplicates of ones in apollo-server-integration-testsuite
// We don't actually expect Jest to do much here, the purpose of these
// tests is to make sure our typings are correct, and to trigger a
// compile error if they aren't
describe('context field', () => {
describe('as a function', () => {
it('can accept and return `req`', () => {