hiro/apollo-server
1
0
Fork 0
mirror of https://github.com/vale981/apollo-server synced 2025-03-06 02:01:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add comment in code about reasoning behind #921.

Browse source 
It's probably helpful for posterity to leave some additional color in
the code to avoid the possibilit of someone inadvertently changing it
without considering the indirect possibilities.

cc @daffl (thanks!)

Ref: https://github.com/apollographql/apollo-server/pull/921
Ref: https://github.com/expressjs/express/issues/3473
This commit is contained in:
Jesse Rosenberger 2018-04-11 12:18:12 +03:00
parent ff154828e7
commit b8ab085aff
No known key found for this signature in database
GPG key ID: C0CCCF81AA6C08D8
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/apollo-server-restify/src/restifyApollo.test.ts
View file

@ -30,6 +30,10 @@ function createApp(options: CreateAppOptions = {}) {
}
describe('graphqlRestify', () => {
// As was reported in https://github.com/apollographql/apollo-server/pull/921,
// Restify monkey-patches Node internals, which can have adverse affects on
// other environmental participants like Express. Therefore, restify is being
// dynamically loaded, rather than imported at top-level.
before(async () => {
const restifyApollo = await import('./restifyApollo');