From 74ca606c8a8bfa8131473219f6a1457aada9d9c3 Mon Sep 17 00:00:00 2001 From: Jesse Rosenberger Date: Wed, 26 Sep 2018 13:29:52 +0300 Subject: [PATCH] Add warning to `.circleci/config.yml` about Node.js version specific tests. Hopefully this will act as reminder for the future. I've used `NODE` here as a sort of `TODO` so other references in the codebase might be more easily located. --- .circleci/config.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 43fcdce7..9cafe5bb 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -48,6 +48,8 @@ jobs: # Platform tests, each with the same tests but different platform or version. # The docker tag represents the Node.js version and the full list is available # at https://hub.docker.com/r/circleci/node/. + + # NODE: Note certain tests are currently being skipped for Node.js 6. Node.js 6: docker: [{ image: 'circleci/node:6' }] <<: *common_test_steps @@ -56,6 +58,7 @@ jobs: docker: [{ image: 'circleci/node:8' }] <<: *common_test_steps + # NODE: Note certain tests are currently being skipped for Node.js 10. Node.js 10: docker: [{ image: 'circleci/node:10' }] <<: *common_test_steps