hiro/apollo-server
1
0
Fork 0
mirror of https://github.com/vale981/apollo-server synced 2025-03-04 17:21:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Tick off Prettier checkmarks, which were present on CI but not locally. (#880)

Browse source 
For reasons unbeknownst to me, the changes below were only being complained
about in the CI environment but _not_ when I ran `npm run lint` locally.

It seems partially related to the OS its ran on, so I imagine there might be
some other sub-dependency at play here.  In an effort to fix this, I just
spawned a Ubuntu docker image, checked out this repository and ran the same
`npm run lint`.  This produced identical results to Travis, so I ran
`npm run lint-fix`, then saved the `git diff` results and have applied this
locally.

This should allow us to re-enable `prettier` in CI, though I have plans to
separate that from the actual `npm test` runs.  This should result in a better
workflow for managing PRs.
This commit is contained in:
Jesse Rosenberger 2018-03-16 10:25:07 +02:00 • committed by GitHub
parent 489c418efb
commit 3a0608ebc5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 32 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/apollo-server-express/package.json
View file

@ -1,7 +1,8 @@
{
"name": "apollo-server-express",
"version": "1.3.2",
"description": "Production-ready Node.js GraphQL server for Express and Connect",
"description":
"Production-ready Node.js GraphQL server for Express and Connect",
"main": "dist/index.js",
"scripts": {
"compile": "tsc",

3
packages/graphql-server-express/package.json
View file

@ -1,7 +1,8 @@
{
"name": "graphql-server-express",
"version": "1.3.2",
"description": "Production-ready Node.js GraphQL server for Express and Connect",
"description":
"Production-ready Node.js GraphQL server for Express and Connect",
"main": "dist/index.js",
"scripts": {
"compile": "tsc",