mirror of
https://github.com/vale981/Vulcan
synced 2025-03-06 10:01:40 -05:00
![]() Currently, ``throwError`` is used for all manner of messages, including errors, "success" messages, and "info" messages. This makes appropriate styling of the error message difficult. In addition, the name ``throwError`` seems to create confusion, implying that an error will actually be thrown (e.g. stopping execution when a user isn't logged in [0][1]), when in fact it just displays a message. Replace ``throwError`` with ``flashMessage``, and reliably include a message "type" (e.g. "error", "success", "info") every time. rename ``lib/errors.js`` to ``lib/messages.js`` to more accurately reflect its function. This commit doesn't rename the message collection (``Errors``), nor the template responsible for rendering the messages (``error_item.html``) -- that should probably still be done, but has higher likelihood of trouble for existing alternate themes and installations. [0] |
||
---|---|---|
.. | ||
config | ||
locales | ||
analytics.js | ||
events.js | ||
helpers.js | ||
messages.js | ||
parameters.js | ||
permissions.js | ||
publications.js | ||
router.js | ||
scoring.js | ||
users.js | ||
version.js | ||
vote.js |