Vulcan/lib
Charlie DeTar ea7efc3550 Replace "throwError" with "flashMessage" and type
Currently, ``throwError`` is used for all manner of messages, including
errors, "success" messages, and "info" messages.  This makes appropriate
styling of the error message difficult.  In addition, the name
``throwError`` seems to create confusion, implying that an error will
actually be thrown (e.g. stopping execution when a user isn't logged in
[0][1]), when in fact it just displays a message.

Replace ``throwError`` with ``flashMessage``, and reliably include a
message "type" (e.g. "error", "success", "info") every time.  rename
``lib/errors.js`` to ``lib/messages.js`` to more accurately reflect its
function.

This commit doesn't rename the message collection (``Errors``), nor the
template responsible for rendering the messages (``error_item.html``) --
that should probably still be done, but has higher likelihood of
trouble for existing alternate themes and installations.

[0] 6ccf7d7d47/client/views/users/user_edit.js (L43)
[1] 083a4c4dc4/client/views/users/user_email.js (L13)
2014-11-05 13:12:09 -07:00
..
config Added validation for username length and password length in sign up form 2014-09-26 17:21:16 +02:00
locales Update it.js 2014-10-05 12:13:28 +02:00
analytics.js cleanup while getting familiar with the codebase 2014-09-16 15:18:27 -04:00
events.js using hotkeys package 2014-07-03 10:15:19 +09:00
helpers.js fix #401 2014-09-23 19:08:49 +00:00
messages.js Replace "throwError" with "flashMessage" and type 2014-11-05 13:12:09 -07:00
parameters.js Fully abstract isAdmin 2014-10-03 16:21:06 -06:00
permissions.js Solve trivial JS errors 2014-05-06 20:15:48 -07:00
publications.js changed the privacyOptions to be a whitelist instead of a blacklist to avoid accidental leak of information. 2014-09-08 13:44:49 +08:00
router.js Replace "throwError" with "flashMessage" and type 2014-11-05 13:12:09 -07:00
scoring.js fixing scoring bug 2014-07-19 09:18:10 +09:00
users.js Fix email_hash bug (Issue #393) 2014-10-15 16:48:04 -05:00
version.js version bump 2014-09-29 15:44:34 +09:00
vote.js Fully abstract isAdmin 2014-10-03 16:21:06 -06:00