hiro/Vulcan
1
0
Fork 0
mirror of https://github.com/vale981/Vulcan synced 2025-03-09 20:16:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
Vulcan/client/views/posts/modules
History
Charlie DeTar ea7efc3550 Replace "throwError" with "flashMessage" and type 
Currently, ``throwError`` is used for all manner of messages, including
errors, "success" messages, and "info" messages.  This makes appropriate
styling of the error message difficult.  In addition, the name
``throwError`` seems to create confusion, implying that an error will
actually be thrown (e.g. stopping execution when a user isn't logged in
[0][1]), when in fact it just displays a message.

Replace ``throwError`` with ``flashMessage``, and reliably include a
message "type" (e.g. "error", "success", "info") every time.  rename
``lib/errors.js`` to ``lib/messages.js`` to more accurately reflect its
function.

This commit doesn't rename the message collection (``Errors``), nor the
template responsible for rendering the messages (``error_item.html``) --
that should probably still be done, but has higher likelihood of
trouble for existing alternate themes and installations.

[0] 6ccf7d7d47/client/views/users/user_edit.js (L43)
[1] 083a4c4dc4/client/views/users/user_email.js (L13)
2014-11-05 13:12:09 -07:00
..
post_actions.html improving base theme 2014-08-20 15:59:11 +09:00
post_actions.js working on mobile version; added new postHeading and postMeta hooks 2014-07-14 10:12:02 +09:00
post_admin.html Fully abstract isAdmin 2014-10-03 16:21:06 -06:00
post_admin.js another jQuery cache 2014-09-16 15:46:48 -04:00
post_comments_link.html Changed comments to CommentsCount; Now tracking _ids of commenters on each Post document 2014-08-22 10:31:05 +09:00
post_content.html making post modules use dynamic templates as well 2014-07-23 10:25:16 +09:00
post_content.js Update to use bengott:avatar package for all user avatars 2014-09-30 12:34:42 -05:00
post_discuss.html Changed comments to CommentsCount; Now tracking _ids of commenters on each Post document 2014-08-22 10:31:05 +09:00
post_domain.html working on mobile version; added new postHeading and postMeta hooks 2014-07-14 10:12:02 +09:00
post_domain.js working on mobile version; added new postHeading and postMeta hooks 2014-07-14 10:12:02 +09:00
post_info.html various small css fixes 2014-09-16 11:51:13 +09:00
post_info.js another jQuery cache 2014-09-16 15:46:48 -04:00
post_title.html working on mobile version; added new postHeading and postMeta hooks 2014-07-14 10:12:02 +09:00
post_title.js working on mobile version; added new postHeading and postMeta hooks 2014-07-14 10:12:02 +09:00
post_upvote.html improving base theme 2014-08-20 15:59:11 +09:00
post_upvote.js Replace "throwError" with "flashMessage" and type 2014-11-05 13:12:09 -07:00