Vulcan/client/views/comments
Charlie DeTar ea7efc3550 Replace "throwError" with "flashMessage" and type
Currently, ``throwError`` is used for all manner of messages, including
errors, "success" messages, and "info" messages.  This makes appropriate
styling of the error message difficult.  In addition, the name
``throwError`` seems to create confusion, implying that an error will
actually be thrown (e.g. stopping execution when a user isn't logged in
[0][1]), when in fact it just displays a message.

Replace ``throwError`` with ``flashMessage``, and reliably include a
message "type" (e.g. "error", "success", "info") every time.  rename
``lib/errors.js`` to ``lib/messages.js`` to more accurately reflect its
function.

This commit doesn't rename the message collection (``Errors``), nor the
template responsible for rendering the messages (``error_item.html``) --
that should probably still be done, but has higher likelihood of
trouble for existing alternate themes and installations.

[0] 6ccf7d7d47/client/views/users/user_edit.js (L43)
[1] 083a4c4dc4/client/views/users/user_email.js (L13)
2014-11-05 13:12:09 -07:00
..
comment_deleted.html Localisation Common, Errors, Notifications and Users 2013-11-06 01:01:56 +01:00
comment_edit.html Do not remove deleted comments from db 2014-09-16 12:12:48 +09:00
comment_edit.js Replace "throwError" with "flashMessage" and type 2014-11-05 13:12:09 -07:00
comment_form.html notifications are now a menu item 2014-08-20 17:03:54 +09:00
comment_form.js Replace "throwError" with "flashMessage" and type 2014-11-05 13:12:09 -07:00
comment_item.html Update to use bengott:avatar 0.1.2 2014-10-13 16:14:48 -05:00
comment_item.js Replace "throwError" with "flashMessage" and type 2014-11-05 13:12:09 -07:00
comment_list.html fixing comment bugs 2014-07-05 16:21:28 +09:00
comment_list.js cleanup while getting familiar with the codebase 2014-09-16 15:18:27 -04:00
comment_reply.html merging comment_page and comment_reply templates 2014-07-07 09:36:38 +09:00
comment_reply.js fixing comment bugs 2014-07-05 16:21:28 +09:00