mirror of
https://github.com/vale981/Vulcan
synced 2025-03-10 04:26:41 -04:00
94c6121d91
This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
47 lines
1.1 KiB
JavaScript
47 lines
1.1 KiB
JavaScript
|
|
Telescope.menus = {};
|
|
|
|
/**
|
|
* Add one or more items to a menu
|
|
* @param {string} menu - The name of the menu
|
|
* @param {Object|Object[]} menu - The menu item object (or an array of items)
|
|
*/
|
|
Telescope.menus.register = function (menu, item) {
|
|
|
|
// if menu items array doesn't exist yet, initialize it
|
|
if (typeof Telescope.menus[menu] === "undefined") {
|
|
Telescope.menus[menu] = [];
|
|
}
|
|
|
|
if (Array.isArray(item)) {
|
|
|
|
var items = item; // we're dealing with an Array, so let's add an "s"
|
|
items.forEach( function (item) {
|
|
Telescope.menus[menu].push(item);
|
|
});
|
|
|
|
} else {
|
|
|
|
Telescope.menus[menu].push(item);
|
|
|
|
}
|
|
};
|
|
|
|
/**
|
|
* Remove an item from a menu
|
|
* @param {string} menu - The name of the menu
|
|
* @param {string} label - The label of the item to remove
|
|
*/
|
|
Telescope.menus.remove = function (menu, label) {
|
|
Telescope.menus[menu] = _.reject(Telescope.menus[menu], function (menu) {
|
|
return menu.label === label;
|
|
});
|
|
};
|
|
|
|
/**
|
|
* Retrieve an array containing all items for a menu
|
|
* @param {string} menu - The name of the menu
|
|
*/
|
|
Telescope.menus.get = function (menu) {
|
|
return _.sortBy(Telescope.menus[menu], "order");
|
|
};
|