mirror of
https://github.com/vale981/Vulcan
synced 2025-03-10 04:26:41 -04:00
94c6121d91
This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
40 lines
1.2 KiB
JavaScript
40 lines
1.2 KiB
JavaScript
compareVersions = function (v1, v2) { // return true if v2 is newer than v1
|
|
var v1Array = v1.split('.');
|
|
var v2Array = v2.split('.');
|
|
var isGreater = false;
|
|
// go through each segment of v2 and stop if we find one that's higher
|
|
// than the equivalent segment of v1; else return false
|
|
v2Array.some( function (value, index) {
|
|
if (parseInt(value) > parseInt(v1Array[index])) {
|
|
// v2 segment > v1 segment
|
|
isGreater = true;
|
|
return true; // stop comparison
|
|
} else if (parseInt(value) < parseInt(v1Array[index])) {
|
|
// v2 segment < v1 segment
|
|
isGreater = false;
|
|
return true; // stop comparison
|
|
}
|
|
return false; // continue comparison as long as both values are equal
|
|
});
|
|
return isGreater;
|
|
};
|
|
|
|
Meteor.startup(function () {
|
|
Session.set('updateVersion', null);
|
|
|
|
Meteor.call('phoneHome', function (error, result) {
|
|
// console.log(error)
|
|
// console.log(result)
|
|
if(result){
|
|
var currentVersion = Telescope.VERSION;
|
|
var newVersion = result.content;
|
|
if (compareVersions(currentVersion, newVersion)){
|
|
Session.set('updateVersion', newVersion);
|
|
}
|
|
}
|
|
});
|
|
});
|
|
|
|
Telescope.modules.register("hero", {
|
|
template: 'updateBanner'
|
|
});
|