mirror of
https://github.com/vale981/Vulcan
synced 2025-03-10 04:26:41 -04:00

This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
179 lines
4.8 KiB
JavaScript
179 lines
4.8 KiB
JavaScript
|
|
// send emails every second when in dev environment
|
|
if (Meteor.absoluteUrl().indexOf('localhost') !== -1)
|
|
Herald.settings.queueTimer = 1000;
|
|
|
|
Meteor.startup(function () {
|
|
|
|
Herald.collection.deny({
|
|
update: !Users.can.editById,
|
|
remove: !Users.can.editById
|
|
});
|
|
|
|
// disable all email notifications when "emailNotifications" is set to false
|
|
Herald.settings.overrides.email = !Settings.get('emailNotifications', true);
|
|
|
|
});
|
|
|
|
var commentEmail = function (userToNotify) {
|
|
var notification = this;
|
|
// put in setTimeout so it doesn't hold up the rest of the method
|
|
Meteor.setTimeout(function () {
|
|
notificationEmail = buildEmailNotification(notification);
|
|
sendEmail(Users.getEmail(userToNotify), notificationEmail.subject, notificationEmail.html);
|
|
}, 1);
|
|
};
|
|
|
|
var getCommenterProfileUrl = function (comment) {
|
|
var user = Meteor.users.findOne(comment.userId);
|
|
if (user) {
|
|
return Users.getProfileUrl(user);
|
|
} else {
|
|
return Users.getProfileUrlBySlugOrId(comment.userId);
|
|
}
|
|
};
|
|
|
|
var getAuthor = function (comment) {
|
|
var user = Meteor.users.findOne(comment.userId);
|
|
if (user) {
|
|
return Users.getUserName(user);
|
|
} else {
|
|
return comment.author;
|
|
}
|
|
};
|
|
|
|
// ------------------------------------------------------------------------------------------- //
|
|
// ----------------------------------------- Posts ------------------------------------------ //
|
|
// ------------------------------------------------------------------------------------------- //
|
|
|
|
Herald.addCourier('newPost', {
|
|
media: {
|
|
email: {
|
|
emailRunner: function (user) {
|
|
var p = Posts.getProperties(this.data);
|
|
var subject = p.postAuthorName+' has created a new post: '+p.postTitle;
|
|
var html = buildEmailTemplate(getEmailTemplate('emailNewPost')(p));
|
|
sendEmail(Users.getEmail(user), subject, html);
|
|
}
|
|
}
|
|
}
|
|
// message: function (user) { return 'email template?' }
|
|
});
|
|
|
|
Herald.addCourier('newPendingPost', {
|
|
media: {
|
|
email: {
|
|
emailRunner: function (user) {
|
|
var p = Posts.getProperties(this.data);
|
|
var subject = p.postAuthorName+' has a new post pending approval: '+p.postTitle;
|
|
var html = buildEmailTemplate(getEmailTemplate('emailNewPendingPost')(p));
|
|
sendEmail(Users.getEmail(user), subject, html);
|
|
}
|
|
}
|
|
}
|
|
});
|
|
|
|
Herald.addCourier('postApproved', {
|
|
media: {
|
|
onsite: {},
|
|
email: {
|
|
emailRunner: function (user) {
|
|
var p = Posts.getProperties(this.data);
|
|
var subject = 'Your post “'+p.postTitle+'” has been approved';
|
|
var html = buildEmailTemplate(getEmailTemplate('emailPostApproved')(p));
|
|
sendEmail(Users.getEmail(user), subject, html);
|
|
}
|
|
}
|
|
},
|
|
message: {
|
|
default: function () {
|
|
return Blaze.toHTML(Blaze.With(this, function () {
|
|
return Template.notificationPostApproved;
|
|
}));
|
|
}
|
|
},
|
|
transform: {
|
|
postUrl: function () {
|
|
var p = Posts.getProperties(this.data);
|
|
return p.postUrl;
|
|
},
|
|
postTitle: function () {
|
|
var p = Posts.getProperties(this.data);
|
|
return p.postTitle;
|
|
}
|
|
}
|
|
});
|
|
|
|
// ------------------------------------------------------------------------------------------- //
|
|
// ---------------------------------------- Comments ----------------------------------------- //
|
|
// ------------------------------------------------------------------------------------------- //
|
|
|
|
// specify how to get properties used in template from comment data
|
|
var commentCourierTransform = {
|
|
profileUrl: function () {
|
|
return getCommenterProfileUrl(this.data.comment);
|
|
},
|
|
postCommentUrl: function () {
|
|
return Router.path('post_page', {_id: this.data.post._id});
|
|
},
|
|
author: function () {
|
|
return getAuthor(this.data.comment);
|
|
},
|
|
postTitle: function () {
|
|
return this.data.post.title;
|
|
},
|
|
url: function () {
|
|
return Router.path('comment_reply', {_id: this.parentComment._id});
|
|
}
|
|
};
|
|
|
|
Herald.addCourier('newComment', {
|
|
media: {
|
|
onsite: {},
|
|
email: {
|
|
emailRunner: commentEmail
|
|
}
|
|
},
|
|
message: {
|
|
default: function () {
|
|
return Blaze.toHTML(Blaze.With(this, function () {
|
|
return Template.notificationNewComment;
|
|
}));
|
|
}
|
|
},
|
|
transform: commentCourierTransform
|
|
});
|
|
|
|
Herald.addCourier('newReply', {
|
|
media: {
|
|
onsite: {},
|
|
email: {
|
|
emailRunner: commentEmail
|
|
}
|
|
},
|
|
message: {
|
|
default: function () {
|
|
return Blaze.toHTML(Blaze.With(this, function () {
|
|
return Template.notificationNewReply;
|
|
}));
|
|
}
|
|
},
|
|
transform: commentCourierTransform
|
|
});
|
|
|
|
Herald.addCourier('newCommentSubscribed', {
|
|
media: {
|
|
onsite: {},
|
|
email: {
|
|
emailRunner: commentEmail
|
|
}
|
|
},
|
|
message: {
|
|
default: function () {
|
|
return Blaze.toHTML(Blaze.With(this, function () {
|
|
return Template.notificationNewReply;
|
|
}));
|
|
}
|
|
},
|
|
transform: commentCourierTransform
|
|
});
|