mirror of
https://github.com/vale981/Vulcan
synced 2025-03-10 12:36:39 -04:00
94c6121d91
This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
53 lines
1.5 KiB
JavaScript
53 lines
1.5 KiB
JavaScript
Template.userDownvotedPosts.created = function () {
|
|
|
|
var user = this.data;
|
|
var instance = this;
|
|
|
|
// initialize the terms and posts local reactive variables
|
|
instance.terms = new ReactiveVar({
|
|
view: 'userDownvotedPosts',
|
|
userId: user._id,
|
|
limit: 5
|
|
});
|
|
instance.posts = new ReactiveVar({});
|
|
|
|
// will re-run when the "terms" local reactive variable changes
|
|
this.autorun(function () {
|
|
|
|
// get the new terms and generate new parameters from them
|
|
var terms = instance.terms.get();
|
|
var parameters = Posts.getSubParams(terms);
|
|
|
|
// subscribe to the userPosts publication
|
|
instance.subscription = Meteor.subscribe('userDownvotedPosts', terms);
|
|
|
|
// update the instance's "posts" cursor
|
|
instance.posts.set(Posts.find(parameters.find, parameters.options));
|
|
|
|
});
|
|
};
|
|
|
|
Template.userDownvotedPosts.helpers({
|
|
posts: function () {
|
|
var user = this;
|
|
var posts = Template.instance().posts.get().fetch();
|
|
posts = _.map(posts, function (post) {
|
|
var vote = _.findWhere(user.telescope.downvotedPosts, {itemId: post._id});
|
|
post.votedAt = vote.votedAt;
|
|
return post;
|
|
});
|
|
return posts;
|
|
},
|
|
hasMorePosts: function () {
|
|
return Template.instance().posts.get().count() >= Template.instance().terms.get().limit;
|
|
}
|
|
});
|
|
|
|
Template.userDownvotedPosts.events({
|
|
'click .downvotedposts-more': function (e) {
|
|
e.preventDefault();
|
|
var terms = Template.instance().terms.get();
|
|
terms.limit += 5;
|
|
Template.instance().terms.set(terms);
|
|
}
|
|
});
|