mirror of
https://github.com/vale981/Vulcan
synced 2025-03-10 12:36:39 -04:00
94c6121d91
This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
61 lines
1.8 KiB
JavaScript
61 lines
1.8 KiB
JavaScript
Template.userPosts.created = function () {
|
|
|
|
var user = this.data;
|
|
var instance = this;
|
|
|
|
// initialize the terms reactive variable
|
|
instance.terms = new ReactiveVar({
|
|
view: 'userPosts',
|
|
userId: user._id,
|
|
limit: 5,
|
|
previousLimit: 0 // should always be equal to limit's previous value
|
|
});
|
|
|
|
// initialize the posts cursor ReVar
|
|
instance.posts = new ReactiveVar({});
|
|
|
|
// initialize the subscription handle ReVar
|
|
instance.subscription = new ReactiveVar({});
|
|
|
|
// will re-run when the "terms" or "subscription" reactive variables change
|
|
this.autorun(function () {
|
|
|
|
// get the new terms and generate new parameters from them
|
|
var terms = instance.terms.get();
|
|
var parameters = Posts.getSubParams(terms);
|
|
|
|
// subscribe to the userPosts publication
|
|
instance.subscription.set(Meteor.subscribe('userPosts', terms));
|
|
|
|
// until subscription is ready, overwrite limit to restrict number of posts to previousLimit
|
|
if (!instance.subscription.get().ready())
|
|
parameters.options.limit = terms.previousLimit;
|
|
|
|
// update the instance's "posts" cursor
|
|
instance.posts.set(Posts.find(parameters.find, parameters.options));
|
|
|
|
});
|
|
};
|
|
|
|
Template.userPosts.helpers({
|
|
posts: function () {
|
|
return Template.instance().posts.get();
|
|
},
|
|
isReady: function () {
|
|
return Template.instance().subscription.get().ready();
|
|
},
|
|
hasMorePosts: function () {
|
|
return Template.instance().posts.get().count() >= Template.instance().terms.get().previousLimit;
|
|
}
|
|
});
|
|
|
|
Template.userPosts.events({
|
|
'click .posts-more': function (e) {
|
|
e.preventDefault();
|
|
var terms = Template.instance().terms.get();
|
|
// previousLimit starts at 0, so by increasing both values by 5 we keep them 5 apart
|
|
terms.previousLimit += 5;
|
|
terms.limit += 5;
|
|
Template.instance().terms.set(terms);
|
|
}
|
|
});
|