mirror of
https://github.com/vale981/Vulcan
synced 2025-03-10 12:36:39 -04:00
94c6121d91
This commit touch a lot of lines of code with the goal to be more rigorous about JavaScript code conventions defined in the `.jshintrc`. Some modification: * Add a list of used global symbols in the corresponding section of `.jshintrc` * Use local variables instead of global in a lot of places where the keyword `var` was mistakenly forgotten * Add missing semi-colons after instructions * Add new lines at the end of files * Remove trailing whitespaces * Use newer name of some Meteor APIs, eg `addFiles` instead of `add_files` * Add missing `break` statements in `switch` blocks * Use `===` instead of `==` and `!==` instead of `!=` * Remove unused variables This commit should also fix a few bugs due to this lack of rigor. One example of that was the test `typeof navElements === "array"` that was never true because in JavaScript, `typeof [] === "object"`, we replaced this test by the `_.isArray` method provided by underscore. It might also fix some potential collision related to global variables. There is still plenty of work until Telescope code base passes jsHint validation, but at least this commit is a step in the right direction.
95 lines
2.8 KiB
JavaScript
95 lines
2.8 KiB
JavaScript
AutoForm.addInputType("bootstrap-postthumbnail", {
|
|
template: "afPostThumbnail"
|
|
});
|
|
|
|
var fillEmbedlyData = function (instance) {
|
|
|
|
// note: the following fields are *not* in the current template
|
|
var $urlField = $('[name="url"]');
|
|
var $titleField = $('[name="title"]');
|
|
var $bodyField = $('[name="body"]');
|
|
var url = $urlField.val();
|
|
|
|
var $thumbnailContainer = instance.$('.post-thumbnail-container');
|
|
var $img = instance.$('.post-thumbnail-preview');
|
|
var $thumbnailUrlField = instance.$('[name="thumbnailUrl"]');
|
|
|
|
if (!!url) {
|
|
$thumbnailContainer.addClass('loading');
|
|
Messages.clearSeen();
|
|
console.log('getting embedly data for '+url);
|
|
Meteor.call('getEmbedlyData', url, function (error, data) {
|
|
if (error) {
|
|
console.log(error);
|
|
Messages.flash(error.message, 'error');
|
|
$thumbnailContainer.removeClass('loading');
|
|
return;
|
|
}
|
|
if (data) {
|
|
// set thumbnail and fill in thumbnailUrl field
|
|
$img.attr('src', data.thumbnailUrl);
|
|
$thumbnailUrlField.val(data.thumbnailUrl);
|
|
|
|
// remove loading class
|
|
$thumbnailContainer.removeClass('loading');
|
|
|
|
if (!$titleField.val()) // if title field is empty, fill in title
|
|
$titleField.val(data.title);
|
|
if (!$bodyField.val()) // if body field is empty, fill in body
|
|
$bodyField.val(data.description);
|
|
|
|
}
|
|
});
|
|
}
|
|
};
|
|
|
|
Template.afPostThumbnail.created = function () {
|
|
var instance = this;
|
|
instance.embedlyKeyExists = new ReactiveVar(false);
|
|
// embedly key is not published to client, so we need a method to test if it has been provided or not
|
|
Meteor.call('embedlyKeyExists', function (error, result) {
|
|
if (result)
|
|
instance.embedlyKeyExists.set(result);
|
|
});
|
|
};
|
|
|
|
Template.afPostThumbnail.helpers({
|
|
atts: function addFormControlAtts() {
|
|
var atts = _.clone(this.atts);
|
|
// Add bootstrap class
|
|
atts = AutoForm.Utility.addClass(atts, "form-control");
|
|
return atts;
|
|
},
|
|
style: function () {
|
|
var thumbnailWidth = Settings.get('thumbnailWidth', 200);
|
|
var thumbnailHeight = Settings.get('thumbnailHeight', 125);
|
|
return "width: "+thumbnailWidth+"px; height: "+thumbnailHeight+"px;";
|
|
},
|
|
embedlyKeyExists: function () {
|
|
// haven't found a better way to do this yet…
|
|
return Template.instance().embedlyKeyExists.get();
|
|
}
|
|
});
|
|
|
|
Template.afPostThumbnail.rendered = function () {
|
|
|
|
var instance = this;
|
|
var $urlField = $('[name="url"]');
|
|
|
|
$urlField.change(function () {
|
|
fillEmbedlyData(instance);
|
|
});
|
|
|
|
};
|
|
|
|
Template.afPostThumbnail.events({
|
|
'click .remove-thumbnail-link': function (e, t) {
|
|
e.preventDefault();
|
|
t.$('.post-thumbnail-preview').attr('src', '');
|
|
t.$('input').val('');
|
|
},
|
|
'click .regenerate-thumbnail-link': function (e, instance) {
|
|
e.preventDefault();
|
|
fillEmbedlyData(instance);
|
|
}
|
|
});
|