hiro/Vulcan
1
0
Fork 0
mirror of https://github.com/vale981/Vulcan synced 2025-03-10 04:26:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
1706 commits 32 branches 57 tags 17 MiB
Commit graph

9 commits

Author SHA1 Message Date
Sacha Greif
ff8bf40694 Merge branch 'telescope-master-semantic-messages' of https://github.com/AdmitHub/Telescope into AdmitHub-telescope-master-semantic-messages 
Conflicts:
	client/helpers/handlebars.js
	client/views/comments/comment_edit.js
	client/views/comments/comment_form.js
	client/views/comments/comment_item.js
	client/views/posts/modules/post_upvote.js
	client/views/posts/post_edit.js
	client/views/posts/post_submit.js
	client/views/users/user_edit.js
	client/views/users/user_email.js
	lib/router.js
	packages/telescope-tags/lib/client/views/category_item.js
 2014-12-06 17:34:08 +09:00
Sacha Greif
82aed922a2 fix mark as read bug 2014-12-01 16:53:41 +09:00
Sacha Greif
0a696ce1e3 internationalizing packages 2014-11-24 11:27:07 +09:00
Sacha Greif
3141c204c2 tweak commentCount migration; fix kadira version; fix path check 2014-11-18 09:56:09 +09:00
Charlie DeTar
ea7efc3550 Replace "throwError" with "flashMessage" and type 
Currently, ``throwError`` is used for all manner of messages, including
errors, "success" messages, and "info" messages.  This makes appropriate
styling of the error message difficult.  In addition, the name
``throwError`` seems to create confusion, implying that an error will
actually be thrown (e.g. stopping execution when a user isn't logged in
[0][1]), when in fact it just displays a message.

Replace ``throwError`` with ``flashMessage``, and reliably include a
message "type" (e.g. "error", "success", "info") every time.  rename
``lib/errors.js`` to ``lib/messages.js`` to more accurately reflect its
function.

This commit doesn't rename the message collection (``Errors``), nor the
template responsible for rendering the messages (``error_item.html``) --
that should probably still be done, but has higher likelihood of
trouble for existing alternate themes and installations.

[0] 6ccf7d7d47/client/views/users/user_edit.js (L43)
[1] 083a4c4dc4/client/views/users/user_email.js (L13)
 2014-11-05 13:12:09 -07:00
Sacha Greif
d277adfc6d wrap newsletter banner helpers in startup block 2014-10-08 11:49:34 +09:00
Sacha Greif
9c1e00ac95 Make no_rights and not_found templates customizable 2014-09-30 15:53:36 +09:00
Sacha Greif
27e274c872 working on alert banner 2014-09-08 17:29:55 +09:00
Sacha Greif
733f367f37 add embedly and newsletter packages 2014-08-29 10:37:35 +09:00