Commit graph

8 commits

Author SHA1 Message Date
Sacha Greif
ff8bf40694 Merge branch 'telescope-master-semantic-messages' of https://github.com/AdmitHub/Telescope into AdmitHub-telescope-master-semantic-messages
Conflicts:
	client/helpers/handlebars.js
	client/views/comments/comment_edit.js
	client/views/comments/comment_form.js
	client/views/comments/comment_item.js
	client/views/posts/modules/post_upvote.js
	client/views/posts/post_edit.js
	client/views/posts/post_submit.js
	client/views/users/user_edit.js
	client/views/users/user_email.js
	lib/router.js
	packages/telescope-tags/lib/client/views/category_item.js
2014-12-06 17:34:08 +09:00
Daniel Chcouri
2605dcb27c Convert translation keys format to tap:i18n standard
all_lower_cased_underscored_sperated names
2014-11-19 00:00:09 +08:00
Charlie DeTar
ea7efc3550 Replace "throwError" with "flashMessage" and type
Currently, ``throwError`` is used for all manner of messages, including
errors, "success" messages, and "info" messages.  This makes appropriate
styling of the error message difficult.  In addition, the name
``throwError`` seems to create confusion, implying that an error will
actually be thrown (e.g. stopping execution when a user isn't logged in
[0][1]), when in fact it just displays a message.

Replace ``throwError`` with ``flashMessage``, and reliably include a
message "type" (e.g. "error", "success", "info") every time.  rename
``lib/errors.js`` to ``lib/messages.js`` to more accurately reflect its
function.

This commit doesn't rename the message collection (``Errors``), nor the
template responsible for rendering the messages (``error_item.html``) --
that should probably still be done, but has higher likelihood of
trouble for existing alternate themes and installations.

[0] 6ccf7d7d47/client/views/users/user_edit.js (L43)
[1] 083a4c4dc4/client/views/users/user_email.js (L13)
2014-11-05 13:12:09 -07:00
Niklas Ström
ed97a26d45 removed the last few references to the old sign in flow - (trying to up up vote comments without being signed in etc.)
also unified all references to /sign-in to use the getSigninUrl()
2014-09-08 01:52:09 +08:00
Sandro Gvelesiani
ff4def6e3f changed the default sign-in route path from /signin to /sign-in 2014-09-01 00:04:21 -07:00
Sacha Greif
30ca584109 fix voting icon bug 2014-07-08 09:06:49 +09:00
Sacha Greif
681be06443 post_item tweaks 2014-07-07 11:49:21 +09:00
Sacha Greif
c36407a7d6 using table layout 2014-07-05 12:30:56 +09:00