This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.
Some modification:
* Add a list of used global symbols in the corresponding section of
`.jshintrc`
* Use local variables instead of global in a lot of places where the
keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
`add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables
This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.
There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
Switched everything over to use can.* functions from telescope-lib instead of using can* functions from lib/permissions.js, deleted lib/permissions.js, added some tests for permissions, and some other random cleanup like deleting unused code.
Conflicts:
client/views/comments/comment_form.js
1) The route /email/campaign was broken in
ceeb7bf531. the method
getNextCampaignSchedule() was removed.
e.g. http://meta.telesc.pe/email/campaign
2) The wrong comment count helper was used in the newsletter template
resulting in it being undefined and so you wouldn’t see a count. I’m
guessing this was broken when the post schema was changed as it comes
from a post’s document.
