Commit graph

19 commits

Author SHA1 Message Date
Sacha Greif
6be2d73d75 namespacing email stuff 2015-05-13 11:52:00 +09:00
Sacha Greif
3c22937896 userCreated -> onCreateUser; fixing getting started package 2015-05-08 11:45:09 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
e0b9bf36b7 namespacing user roles 2015-04-27 17:14:07 +09:00
Sacha Greif
36e2d063ce nicer API namespacing 2015-04-24 09:48:36 +09:00
Sacha Greif
ab77526a0f namespacing and refactoring template modules 2015-04-23 17:45:37 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
43b7256680 Packageifying… 2015-04-21 11:02:02 +09:00
Sacha Greif
50fc3eb11a Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
# Conflicts:
#	lib/users.js
#	packages/telescope-base/lib/base.js
#	packages/telescope-base/package.js
#	packages/telescope-lib
2015-04-20 13:57:37 +09:00
Delgermurun
16d9eaf0f9 Delete all getTemplate related codes 2015-04-13 16:29:33 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Sacha Greif
aba323695f do not fetch remote resources with juice; upgrade packages 2015-02-22 08:52:20 +01:00
Sacha Greif
c9693436c3 fixing context issues on comment form 2015-01-20 12:35:09 +09:00
Sacha Greif
1eb72079b4 adding userCreatedCallbacks callback hook and refactoring user creation 2014-12-13 14:02:45 +09:00
Sacha Greif
eb082473ed refactor server-side email template routes 2014-11-19 15:14:54 +09:00
Sacha Greif
c335d654c9 fixing missing username in notifications; cleaning up console.logs 2014-11-18 11:00:38 +09:00
Sacha Greif
a3c89093ca remove mentions of nom juice package 2014-08-29 13:40:30 +09:00
Sacha Greif
266947e878 split out juice into its own package 2014-08-29 13:32:13 +09:00
Sacha Greif
8ae358181e Got rid of meteorhacks:npm packages; moved email features to their own package 2014-08-29 10:23:11 +09:00