Commit graph

67 commits

Author SHA1 Message Date
Sacha Greif
767d4b8178 template camelCase -> underscore 2015-05-18 10:00:41 +09:00
Sacha Greif
affec3c1c8 using spacebars helpers for profileUrl, username, and displayName 2015-05-14 16:42:19 +09:00
Sacha Greif
b62419ab69 Add debug view for template modules 2015-05-10 13:37:19 +09:00
Sacha Greif
09eb158e3e clean up 2015-05-08 09:44:06 +09:00
Sacha Greif
80750f83ac UI.registerHelper -> Template.registerHelper; fix logo 2015-05-02 11:45:25 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
e0b9bf36b7 namespacing user roles 2015-04-27 17:14:07 +09:00
Sacha Greif
964f91aa88 refactoring menus API 2015-04-24 10:49:24 +09:00
Sacha Greif
7770c21d3a Making module system more flexible to accept wrapping divs 2015-04-24 10:22:17 +09:00
Sacha Greif
36e2d063ce nicer API namespacing 2015-04-24 09:48:36 +09:00
Sacha Greif
8e5446cc75 refactoring custom fields 2015-04-24 09:28:50 +09:00
Sacha Greif
eb0aba65e5 simplifying modules code 2015-04-24 08:13:41 +09:00
Sacha Greif
ab77526a0f namespacing and refactoring template modules 2015-04-23 17:45:37 +09:00
Sacha Greif
d675b21e27 more namespacing 2015-04-23 10:39:58 +09:00
Sacha Greif
443ab712cf move users templates and menu and postList components 2015-04-22 12:20:21 +09:00
Sacha Greif
362506a199 move core templates 2015-04-22 12:14:59 +09:00
Sacha Greif
93a3861265 trackEvent > Events.track; add files to telescope:core 2015-04-22 11:49:42 +09:00