Commit graph

21 commits

Author SHA1 Message Date
Sacha Greif
d4bafd2228 updating menus to work with new menu component options 2015-10-19 10:39:57 +09:00
Sacha Greif
2a3981253e refactor modules code a bit; still working on menu component 2015-10-08 11:13:48 +09:00
Sacha Greif
a503772f87 fix post categories links and i18n issue 2015-09-23 10:23:39 +09:00
Sacha Greif
01fa2db936 Menus refactoring 2015-08-21 10:20:48 +09:00
Sacha Greif
af55ad222e refactor notifications menu code; add hasNotifications helper 2015-07-14 12:57:40 +09:00
Sacha Greif
5f9bd0d223 more template name changes 2015-05-18 10:12:48 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Delgermurun
666577f4cb Template[getTemplate('XYZ')] => Template.XYZ 2015-04-13 14:52:03 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Sacha Greif
35efbeb3ee refactoring menu component 2015-03-28 10:54:41 +09:00
Sacha Greif
8fc95a316c fix mobile nav 2015-03-24 17:03:37 +09:00
Sacha Greif
9c5d3534cb refactoring dropdown CSS 2015-03-23 11:28:36 +09:00
Sacha Greif
51b52da004 working on admin menu 2015-03-23 10:32:56 +09:00
Sacha Greif
7de8974fc4 fixing top nav & notifications 2015-03-22 12:27:05 +09:00
Sacha Greif
82aed922a2 fix mark as read bug 2014-12-01 16:53:41 +09:00
Sacha Greif
0a696ce1e3 internationalizing packages 2014-11-24 11:27:07 +09:00
Daniel Chcouri
2605dcb27c Convert translation keys format to tap:i18n standard
all_lower_cased_underscored_sperated names
2014-11-19 00:00:09 +08:00
Kestanous
9be1bd7169 herald integration 2014-10-02 16:42:31 -04:00
Sacha Greif
2a911217e9 Making notifications into their own package 2014-09-20 09:57:09 +09:00
Renamed from client/views/nav/notifications_menu.js (Browse further)