Commit graph

21 commits

Author SHA1 Message Date
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
9c5e3a56c6 Make optional packages depend on core only 2015-04-22 16:52:42 +09:00
Sacha Greif
5a9b8dd7d2 getting core packages to work 2015-04-22 15:49:46 +09:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
a44ce82a4c telescope:daily and telescope:singleday 2015-04-20 16:40:23 +09:00
Sacha Greif
6d980f9325 change package names; remove submodules 2015-04-20 14:58:48 +09:00
Sacha Greif
50fc3eb11a Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
# Conflicts:
#	lib/users.js
#	packages/telescope-base/lib/base.js
#	packages/telescope-base/package.js
#	packages/telescope-lib
2015-04-20 13:57:37 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Sacha Greif
ae9c1fa59b Add load more days link 2015-01-09 16:05:00 +09:00
Sacha Greif
c71f7c0441 add before/after day templates to daily view 2015-01-03 10:14:39 +09:00
Sacha Greif
2d911f2836 renaming digest package to singleday package 2014-12-08 11:41:28 +09:00
Sacha Greif
75bd8d9920 extracting digest into its own package 2014-12-08 11:15:20 +09:00
Arunoda Susiripala
75278fbae2 added fast-render 2.0 support 2014-11-27 17:25:01 +05:30
Sacha Greif
42aa4bd0d9 use zh-CN as code for Chinese 2014-11-24 11:38:57 +09:00
Sacha Greif
0a696ce1e3 internationalizing packages 2014-11-24 11:27:07 +09:00
Sacha Greif
7b89c604a5 working on package i18n 2014-11-20 14:56:29 +09:00
Sacha Greif
f704c812ef Fixed rss package 2014-08-28 13:39:30 +09:00
Sacha Greif
11dc51b31d bringing back newsletter and embedly modules in core codebase and updating all packages to 0.9.0 2014-08-28 13:24:28 +09:00
Sacha Greif
fa8691eaaf making default view configurable 2014-08-28 10:16:17 +09:00
Sacha Greif
3b1cff9347 working on daily view 2014-08-27 10:23:56 +09:00
Sacha Greif
85679ded35 working on daily view 2014-08-27 09:24:37 +09:00