Commit graph

36 commits

Author SHA1 Message Date
Sacha Greif
03922286e1 refactoring comment form code and fixing upvote issue 2014-12-28 12:13:13 +09:00
Sacha Greif
7d7a3939fc working on comment form latency compensation 2014-12-28 11:45:35 +09:00
Sacha Greif
e91d60ecc9 fix child comment bug 2014-12-27 22:12:01 +09:00
Sacha Greif
c74a9ae8b0 add loading indicators to forms 2014-12-27 18:34:01 +09:00
Sacha Greif
f2760f9168 refactoring comment submit method 2014-12-24 10:13:48 +09:00
Sacha Greif
ff8bf40694 Merge branch 'telescope-master-semantic-messages' of https://github.com/AdmitHub/Telescope into AdmitHub-telescope-master-semantic-messages
Conflicts:
	client/helpers/handlebars.js
	client/views/comments/comment_edit.js
	client/views/comments/comment_form.js
	client/views/comments/comment_item.js
	client/views/posts/modules/post_upvote.js
	client/views/posts/post_edit.js
	client/views/posts/post_submit.js
	client/views/users/user_edit.js
	client/views/users/user_email.js
	lib/router.js
	packages/telescope-tags/lib/client/views/category_item.js
2014-12-06 17:34:08 +09:00
Sacha Greif
45ccf1d8f1 Merge pull request #588 from anthonymayer/urls_by_route_name
Switching from manually generating urls to using IronRouter functions.
2014-12-04 11:44:44 +09:00
Sacha Greif
f06b43b603 finish epic editor clean up and fix #591 2014-12-04 11:32:44 +09:00
Anthony Mayer
23b72b9cb8 Switching from manually generating urls to using IronRouter functions.
Using {{pathFor}}, path(), and url() where possible. Passing in path
to Meteor.absoluteUrl() where the IronRouter functions didn't make sense.
Also deleting some random unused code.
2014-12-03 00:06:00 -08:00
Charlie DeTar
ea7efc3550 Replace "throwError" with "flashMessage" and type
Currently, ``throwError`` is used for all manner of messages, including
errors, "success" messages, and "info" messages.  This makes appropriate
styling of the error message difficult.  In addition, the name
``throwError`` seems to create confusion, implying that an error will
actually be thrown (e.g. stopping execution when a user isn't logged in
[0][1]), when in fact it just displays a message.

Replace ``throwError`` with ``flashMessage``, and reliably include a
message "type" (e.g. "error", "success", "info") every time.  rename
``lib/errors.js`` to ``lib/messages.js`` to more accurately reflect its
function.

This commit doesn't rename the message collection (``Errors``), nor the
template responsible for rendering the messages (``error_item.html``) --
that should probably still be done, but has higher likelihood of
trouble for existing alternate themes and installations.

[0] 6ccf7d7d47/client/views/users/user_edit.js (L43)
[1] 083a4c4dc4/client/views/users/user_email.js (L13)
2014-11-05 13:12:09 -07:00
Mitchell Wulfman
6fc6b9eb78 cleanup while getting familiar with the codebase 2014-09-16 15:18:27 -04:00
Sacha Greif
d375bc3c1b Using templates for on-site notifications too; refactoring a lot of stuff 2014-08-04 11:22:43 +09:00
Sacha Greif
fa25d69444 fixing comment bugs 2014-07-05 16:21:28 +09:00
Sacha Greif
c483464f4d making all template helpers dynamic 2014-07-05 11:24:28 +09:00
Sacha Greif
30d1fa073d cleaning up and refactoring 2014-06-27 19:42:33 +09:00
Sacha Greif
7f99b09e75 Fixing child comment bug 2014-05-08 15:35:47 +09:00
Tarang Patel
39eb1c8e0a Update Events
Move from using depreciated event declaration style. Still supported
not sure if future proof (see
https://github.com/meteor/meteor/blob/devel/packages/templating/deftempl
ate.js#L184)
2013-11-24 16:13:53 +02:00
Sacha Greif
2ce9d4022e adding a subscription for commenting users 2013-10-21 23:07:36 +08:00
Sacha Greif
83d792188b make nested comments optional + various tweaks 2013-10-14 12:14:12 +09:00
Sacha Greif
2d8df6b3c2 working on comment reply 2013-10-09 20:11:58 +09:00
Sacha Greif
9066839a29 working on post and comment 2013-10-09 12:39:05 +09:00
Sacha Greif
f14627bfc2 fixed queued comments bug 2013-04-26 17:28:09 +09:00
Tom Coleman
72d8115b1b New router is working, to some degree.
I switched over to router 2.0, and refactored the permissions a bit.
There's still a bit of work needed to get the permissions fully up to speed.
2012-11-21 14:28:18 +11:00
Sacha Greif
159492d12e cleaned up router 2012-10-11 08:23:52 +09:00
Julien Chaumond
3126c5b566 Keyboard shortcut for posting/editing a comment 2012-10-08 15:11:35 +02:00
Sacha Greif
9cc4d03b93 moved notifications to server side only 2012-10-08 11:23:12 +09:00
Sacha Greif
0c1e6e3656 error tweaks 2012-10-08 10:46:59 +09:00
Sacha Greif
3f180f027b added rate limiting to posts and comments posting 2012-10-06 13:15:55 +09:00
Sacha Greif
4e74d43b06 improving permissions 2012-10-05 22:09:13 +09:00
Sacha Greif
c80f4b3cdd gave notifications its own collection and styled notifcation widget 2012-10-05 10:23:38 +09:00
Sacha Greif
5af2fde974 improving notifications UI 2012-10-04 17:25:10 +09:00
Sacha Greif
ea7a447331 moved notifications server side 2012-10-04 15:26:59 +09:00
Sacha Greif
cd362b6856 bugfix 2012-10-04 15:02:12 +09:00
Sacha Greif
a751fa1627 working on notifications 2012-10-04 14:54:26 +09:00
Sacha Greif
71b0be591c working on notifications 2012-10-04 13:30:57 +09:00
Tom Coleman
e4f55a6377 Start of reorganization. 2012-10-04 11:17:57 +10:00
Renamed from client/templates/comment_form.js (Browse further)