Commit graph

13 commits

Author SHA1 Message Date
Sacha Greif
b15d9095c0 add email testing routes for post approved, new comment, and new reply; clean up notifications; clean up posts, comments, user, utils helpers; change post URL format to /id/slug 2015-06-19 11:52:57 +09:00
Sacha Greif
6be2d73d75 namespacing email stuff 2015-05-13 11:52:00 +09:00
Sacha Greif
0fd0407d4e working on users package and migrating email_hash to emailHash 2015-05-06 12:16:50 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Sacha Greif
50fc3eb11a Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
# Conflicts:
#	lib/users.js
#	packages/telescope-base/lib/base.js
#	packages/telescope-base/package.js
#	packages/telescope-lib
2015-04-20 13:57:37 +09:00
Sacha Greif
3b51d0ef1c bunch of small fixes 2015-01-20 16:18:27 +09:00
Sacha Greif
bc6987dda7 refactoring notifications and adding notifications for post subscribers 2015-01-20 11:59:40 +09:00
Anthony Mayer
e71be66c57 Should fix various url problems by taking siteUrl into account when getting route urls.
Trying to make as much use of path as possible on the client side.
2014-12-09 09:29:17 -08:00
Anthony Mayer
23b72b9cb8 Switching from manually generating urls to using IronRouter functions.
Using {{pathFor}}, path(), and url() where possible. Passing in path
to Meteor.absoluteUrl() where the IronRouter functions didn't make sense.
Also deleting some random unused code.
2014-12-03 00:06:00 -08:00
Kestanous
9be1bd7169 herald integration 2014-10-02 16:42:31 -04:00
Sacha Greif
2a911217e9 Making notifications into their own package 2014-09-20 09:57:09 +09:00
Renamed from server/notifications.js (Browse further)