Commit graph

20 commits

Author SHA1 Message Date
Sacha Greif
c206230ee5 completely refactor notifications code 2015-06-24 15:38:14 +09:00
Sacha Greif
b15d9095c0 add email testing routes for post approved, new comment, and new reply; clean up notifications; clean up posts, comments, user, utils helpers; change post URL format to /id/slug 2015-06-19 11:52:57 +09:00
Sacha Greif
5f9bd0d223 more template name changes 2015-05-18 10:12:48 +09:00
Sacha Greif
6be2d73d75 namespacing email stuff 2015-05-13 11:52:00 +09:00
Maxime Quandalle
94c6121d91 Improve jsHint consistency
This commit touch a lot of lines of code with the goal to be more
rigorous about JavaScript code conventions defined in the `.jshintrc`.

Some modification:

* Add a list of used global symbols in the corresponding section of
  `.jshintrc`
* Use local variables instead of global in a lot of places where the
  keyword `var` was mistakenly forgotten
* Add missing semi-colons after instructions
* Add new lines at the end of files
* Remove trailing whitespaces
* Use newer name of some Meteor APIs, eg `addFiles` instead of
  `add_files`
* Add missing `break` statements in `switch` blocks
* Use `===` instead of `==` and `!==` instead of `!=`
* Remove unused variables

This commit should also fix a few bugs due to this lack of rigor. One
example of that was the test `typeof navElements === "array"` that was
never true because in JavaScript, `typeof [] === "object"`, we
replaced this test by the `_.isArray` method provided by underscore.
It might also fix some potential collision related to global
variables.

There is still plenty of work until Telescope code base passes jsHint
validation, but at least this commit is a step in the right direction.
2015-05-01 18:38:27 +02:00
Sacha Greif
08c6e373fc bringing packages back into core repo after all 2015-04-22 07:50:11 +09:00
Sacha Greif
3d383e06e1 more packageification; removed meteor hacks:npm; changed telescope-blank to custom 2015-04-21 11:42:47 +09:00
Sacha Greif
50fc3eb11a Merge branch 'namespace' of https://github.com/TelescopeJS/Telescope into namespace
# Conflicts:
#	lib/users.js
#	packages/telescope-base/lib/base.js
#	packages/telescope-base/package.js
#	packages/telescope-lib
2015-04-20 13:57:37 +09:00
Delgermurun
666577f4cb Template[getTemplate('XYZ')] => Template.XYZ 2015-04-13 14:52:03 +09:00
Delgermurun
057580b793 Settings package 2015-03-28 18:38:20 +09:00
Sacha Greif
c38c1c6434 fixing email notification templates 2015-01-22 09:19:52 +09:00
Sacha Greif
333b64ae45 adding notifications for approved posts for both admins and end users 2015-01-21 16:47:22 +09:00
Sacha Greif
3b51d0ef1c bunch of small fixes 2015-01-20 16:18:27 +09:00
Sacha Greif
bdf9945440 fixing notifications edge cases 2015-01-20 12:35:25 +09:00
Anthony Mayer
f197b930e6 Cleaning up vote click handling functions and adding tests.
Also combining can.upvote and can.downvote and deleting unused permissions function and random cleanup.
2015-01-19 00:04:41 -08:00
Anthony Mayer
23b72b9cb8 Switching from manually generating urls to using IronRouter functions.
Using {{pathFor}}, path(), and url() where possible. Passing in path
to Meteor.absoluteUrl() where the IronRouter functions didn't make sense.
Also deleting some random unused code.
2014-12-03 00:06:00 -08:00
Sacha Greif
c3eaf39678 refactoring notifications profileUrl and author 2014-11-18 11:05:15 +09:00
Sacha Greif
c335d654c9 fixing missing username in notifications; cleaning up console.logs 2014-11-18 11:00:38 +09:00
Sacha Greif
7b430bff72 re-enable emailNotifications setting 2014-10-07 13:45:48 +09:00
Kestanous
9be1bd7169 herald integration 2014-10-02 16:42:31 -04:00